Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to the --disable-outbound-traffic-protection VPC cluster create flag #5247

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Add support to the --disable-outbound-traffic-protection VPC cluster create flag #5247

merged 3 commits into from
Apr 2, 2024

Conversation

golibali
Copy link
Contributor

@golibali golibali commented Mar 28, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVPCClusterDisableOutboundTrafficProtection'
...
--- PASS: TestAccIBMContainerVPCClusterDisableOutboundTrafficProtection (4630.95s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes	4631.061s

@golibali golibali marked this pull request as ready for review March 28, 2024 14:13
z0za
z0za reviewed Mar 28, 2024
View reviewed changes
ibm/service/kubernetes/resource_ibm_container_vpc_cluster.go
@@ -340,6 +340,14 @@ func ResourceIBMContainerVpcCluster() *schema.Resource {
DiffSuppressFunc: flex.ApplyOnce,
},

"disable_outbound_traffic_protection": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add this field to the documentation too
https://github.com/IBM-Cloud/terraform-provider-ibm/blob/master/website/docs/r/container_vpc_cluster.html.markdown

@hkantare
Copy link
Collaborator

Add the field to respective documentation

@hkantare hkantare merged commit cf4f926 into IBM-Cloud:master Apr 2, 2024
1 check passed
ismirlia pushed a commit to powervs-ibm/terraform-provider-ibm that referenced this pull request Apr 11, 2024
@golibali @ismirlia
Add support to the --disable-outbound-traffic-protection VPC cluster …
34df5a0 
…create flag (IBM-Cloud#5247)

* Add support to the --disable-outbound-traffic-protection VPC cluster create flag

* Add UT and some uncommitted UT update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z0za z0za z0za left review comments

@hkantare hkantare hkantare approved these changes

@Blintmester Blintmester Blintmester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@golibali @hkantare @z0za @Blintmester