fix(Catalog Management): fix cm validation resource panic

[benbuchanan]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Fixes bug with cm validation resource's environment variables argument

Output from acceptance testing:

TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmCatalogBasic -timeout 700m
=== RUN   TestAccIBMCmCatalogBasic
--- PASS: TestAccIBMCmCatalogBasic (23.90s)
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmCatalogSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmCatalogSimpleArgs
--- PASS: TestAccIBMCmCatalogSimpleArgs (31.85s)
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmCatalogDataSourceBasic -timeout 700m
=== RUN   TestAccIBMCmCatalogDataSourceBasic
--- PASS: TestAccIBMCmCatalogDataSourceBasic (21.18s)
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmCatalogDataSourceSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmCatalogDataSourceSimpleArgs
--- PASS: TestAccIBMCmCatalogDataSourceSimpleArgs (19.83s)
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmOfferingBasic -timeout 700m
=== RUN   TestAccIBMCmOfferingBasic
--- PASS: TestAccIBMCmOfferingBasic (23.49s)
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmOfferingSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmOfferingSimpleArgs
--- PASS: TestAccIBMCmOfferingSimpleArgs (31.00s)
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmOfferingDataSourceBasic -timeout 700m
=== RUN   TestAccIBMCmOfferingDataSourceBasic
--- PASS: TestAccIBMCmOfferingDataSourceBasic (22.82s)
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmOfferingDataSourceSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmOfferingDataSourceSimpleArgs
--- PASS: TestAccIBMCmOfferingDataSourceSimpleArgs (21.47s)
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmVersionBasic -timeout 700m
=== RUN   TestAccIBMCmVersionBasic
--- PASS: TestAccIBMCmVersionBasic (25.18s)
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmVersionSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmVersionSimpleArgs
--- PASS: TestAccIBMCmVersionSimpleArgs (23.55s)
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmVersionDataSourceSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmVersionDataSourceSimpleArgs
--- PASS: TestAccIBMCmVersionDataSourceSimpleArgs (23.71s)

[hkantare]

Can we have testcase added for this scenario

[benbuchanan]

@hkantare added test case

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccIBMCmValidationSimpleArgs -timeout 700m
=== RUN   TestAccIBMCmValidationSimpleArgs
--- PASS: TestAccIBMCmValidationSimpleArgs (98.80s)