Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mtu requirement bug #5027

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix mtu requirement bug #5027

merged 1 commit into from
Jan 10, 2024

Conversation

ismirlia
Copy link
Collaborator

@ismirlia ismirlia commented Jan 5, 2024

There a bug with the MTU field in terraform where ExactlyOneOf requires Jumbo or MTU to be set, but the intent was to allow at most one of those fields to be set, but are optional.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ismirlia
Fix mtu requirement bug
d3361c5 
There a bug with the MTU field in terraform where ExactlyOneOf
requires Jumbo or MTU to be set, but the intent was to allow
at most one of those fields to be set, but are optional.
yussufsh
yussufsh approved these changes Jan 8, 2024
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yussufsh yussufsh requested a review from hkantare January 8, 2024 04:37
@yussufsh yussufsh added the service/Power Systems Issues related to Power Systems label Jan 8, 2024
@hkantare hkantare merged commit dfb2339 into IBM-Cloud:master Jan 10, 2024
1 check passed
@ismirlia ismirlia mentioned this pull request Mar 6, 2024
Closed
@michaelkad michaelkad deleted the mtu-bug branch May 28, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yussufsh yussufsh yussufsh approved these changes

@michaelkad michaelkad Awaiting requested review from michaelkad

@hkantare hkantare Awaiting requested review from hkantare

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ismirlia @yussufsh @hkantare