Billing Snapshot Config APIs introduced in Usage Reports #4805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavya498
reviewed
Sep 22, 2023
ibm/service/usagereports/resource_ibm_billing_report_snapshot.go
Outdated
Show resolved
Hide resolved
manukm-ibm
force-pushed
the
billing-snapshot-config
branch
2 times, most recently
from
fe272e9
to
ed1cd8c
Compare
author manu.k.m <[email protected]> 1694802214 +0530 committer manu.k.m <[email protected]> 1697119063 +0530 parent 0a7ebd9 author manu.k.m <[email protected]> 1694802214 +0530 committer manu.k.m <[email protected]> 1697118987 +0530 parent 0a7ebd9 author manu.k.m <[email protected]> 1694802214 +0530 committer manu.k.m <[email protected]> 1697118762 +0530 parent 0a7ebd9 author manu.k.m <[email protected]> 1694802214 +0530 committer manu.k.m <[email protected]> 1697118385 +0530 parent 0a7ebd9 author manu.k.m <[email protected]> 1694802214 +0530 committer manu.k.m <[email protected]> 1697117979 +0530 Billing Snapshot Config APIs introduced in Usage Reports Add example for html Set account id from the token add support for endpoint parameter in cluster_config (IBM-Cloud#4793) * add support for endpoint parameter in cluster_config * adding unit tests for endpoint_type parameter * remove default value "true" as the would be invalid * update documentation remove bluemix-go replace * update bluemix-go + run go mod tidy fix(share-iops): Share Iops range fix for dp2 update metadata update CHANGELOG Bump up version to 1.58.0-beta0 Update examples minor fixes dependabot: bump github.com/hashicorp/vault from 1.13.5 to 1.13.7 Bumps [github.com/hashicorp/vault](https://github.com/hashicorp/vault) from 1.13.5 to 1.13.7. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v1.13.5...v1.13.7) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> New CD Toolchains datasource (IBM-Cloud#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test support for vpc dns resolution binding (IBM-Cloud#4816) * support for vpc dns resolution binding * Update vpc_v1.go dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (IBM-Cloud#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <[email protected]> * re-ran fmt Signed-off-by: Shaun Colley <[email protected]> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <[email protected]> --------- Signed-off-by: Shaun Colley <[email protected]> Update bluemix-go (IBM-Cloud#4822) * update bluemix-go * update doc based on the latest changes Fix document category feat: adding the fields region and instance_id in the service scc (IBM-Cloud#4823) * adding the utility file for generic use * adding the usage of instanceID to control library, profile, profile attachment, rule * updated all testing * Adding the ability to change the URL from provider field, and updated resource docs * updated the docs with the usage of instance_id * added instance_id to the examples * Using the new version of scc-go-sdk * Formatting the docs and added the warn in acctest Signed-off-by: Timothy-Yao <[email protected]> * modifying the PreCheck for Tests * adding the additional line for accPreCheck * Took out os from the testing packages. * Upgrading scc-go-sdk to 5.1.2 and updated functions --------- Signed-off-by: Timothy-Yao <[email protected]> Co-authored-by: Timothy-Yao <[email protected]> documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (IBM-Cloud#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata update CHANGELOG Bump up version to 1.58.0 update bluemix-go to get latest changes Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (IBM-Cloud#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <[email protected]> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <[email protected]> --------- Signed-off-by: ADYA NAND JHA <[email protected]> Fix for issue 4838 (IBM-Cloud#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1 fmt fixes Region update Get secret by name (IBM-Cloud#4825) * Get secret by name * Applying review comments * Added test cases for get secret by name * Added test cases for get secret by name * Updated documentation --------- Co-authored-by: Avi Ribchinsky <[email protected]> dependabot: bump golang.org/x/net from 0.12.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> add support for endpoint parameter in cluster_config (IBM-Cloud#4793) * add support for endpoint parameter in cluster_config * adding unit tests for endpoint_type parameter * remove default value "true" as the would be invalid * update documentation remove bluemix-go replace * update bluemix-go + run go mod tidy fix(share-iops): Share Iops range fix for dp2 New CD Toolchains datasource (IBM-Cloud#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test support for vpc dns resolution binding (IBM-Cloud#4816) * support for vpc dns resolution binding * Update vpc_v1.go dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (IBM-Cloud#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <[email protected]> * re-ran fmt Signed-off-by: Shaun Colley <[email protected]> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <[email protected]> --------- Signed-off-by: Shaun Colley <[email protected]> Update bluemix-go (IBM-Cloud#4822) * update bluemix-go * update doc based on the latest changes Fix document category feat: adding the fields region and instance_id in the service scc (IBM-Cloud#4823) * adding the utility file for generic use * adding the usage of instanceID to control library, profile, profile attachment, rule * updated all testing * Adding the ability to change the URL from provider field, and updated resource docs * updated the docs with the usage of instance_id * added instance_id to the examples * Using the new version of scc-go-sdk * Formatting the docs and added the warn in acctest Signed-off-by: Timothy-Yao <[email protected]> * modifying the PreCheck for Tests * adding the additional line for accPreCheck * Took out os from the testing packages. * Upgrading scc-go-sdk to 5.1.2 and updated functions --------- Signed-off-by: Timothy-Yao <[email protected]> Co-authored-by: Timothy-Yao <[email protected]> documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (IBM-Cloud#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (IBM-Cloud#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <[email protected]> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <[email protected]> --------- Signed-off-by: ADYA NAND JHA <[email protected]> Fix for issue 4838 (IBM-Cloud#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1 Get secret by name (IBM-Cloud#4825) * Get secret by name * Applying review comments * Added test cases for get secret by name * Added test cases for get secret by name * Updated documentation --------- Co-authored-by: Avi Ribchinsky <[email protected]> dependabot: bump golang.org/x/net from 0.12.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Fix handling of bundle_certs in Secrets Manager public cert add support for endpoint parameter in cluster_config (IBM-Cloud#4793) * add support for endpoint parameter in cluster_config * adding unit tests for endpoint_type parameter * remove default value "true" as the would be invalid * update documentation remove bluemix-go replace * update bluemix-go + run go mod tidy fix(share-iops): Share Iops range fix for dp2 New CD Toolchains datasource (IBM-Cloud#4779) * New CD Toolchains datasource * Update secrets baseline * Use latest CD sdk * Fixed acceptance test dependabot: bump actions/checkout from 4.0.0 to 4.1.0 Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.0.0...v4.1.0) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy (IBM-Cloud#4804) * fix(IAM Policy Management): allow sourceServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): minor update to test case and fmt Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): allow targetServiceName to be optional for authorization policy Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): update based on feedback Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Access Management): update schema for feedback Signed-off-by: Shaun Colley <[email protected]> * re-ran fmt Signed-off-by: Shaun Colley <[email protected]> * Update documentation to say which attributes are minimally required Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): updating datasource changes Signed-off-by: Shaun Colley <[email protected]> * fix(IAM Policy Management): fix data source doc to not include unnecessary info Signed-off-by: Shaun Colley <[email protected]> --------- Signed-off-by: Shaun Colley <[email protected]> Update bluemix-go (IBM-Cloud#4822) * update bluemix-go * update doc based on the latest changes Fix document category documents update and test case update for ibm_is_vpc fix(VSI-Profile-patch): Remove validation for VSI profile patching Documentation update for COS static webhosting. (IBM-Cloud#4827) * Updating the COS static webhosting documentation * Documentation update * Removing documentation error * Addressing the review comments update metadata Metrics router and atracker: Updated platform-services-go-sdk to fetch Madrid endpoint (IBM-Cloud#4830) * fix(Metrics router) Updated platform-services-go-sdk to fetch Madrid endpoint Signed-off-by: ADYA NAND JHA <[email protected]> * fix(atracker) Help Message changes Signed-off-by: ADYA NAND JHA <[email protected]> --------- Signed-off-by: ADYA NAND JHA <[email protected]> Fix for issue 4838 (IBM-Cloud#4840) resilence 409 and update docs to include force_delete flag and force_delete=true in examples update CHANGELOG Bump up version to 1.58.1 Get secret by name (IBM-Cloud#4825) * Get secret by name * Applying review comments * Added test cases for get secret by name * Added test cases for get secret by name * Updated documentation --------- Co-authored-by: Avi Ribchinsky <[email protected]> dependabot: bump golang.org/x/net from 0.12.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.12.0 to 0.17.0. - [Commits](golang/net@v0.12.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Fix handling of bundle_certs in Secrets Manager public cert
manukm-ibm
force-pushed
the
billing-snapshot-config
branch
from
363350d
to
95f4a3a
Compare
kavya498
requested changes
Oct 17, 2023
ibm/service/usagereports/data_source_ibm_billing_snapshot_list.go
Outdated
Show resolved
Hide resolved
kavya498
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kavya498 @hkantare Could you please review this PR
Output from acceptance testing: