-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description for keys and force_delete for deleteKeyRings for IBM KMS #4767
Add description for keys and force_delete for deleteKeyRings for IBM KMS #4767
Conversation
… sensitive for kms_key and others, fixed docs where expiration date specified milliseconds which forces perma replacement in terraform, made deprecation for kp_key in docs more visible
Tested force delete in preprod
|
…neric builder format, added new key ring force delete test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All minor things.
## Deprecation Notice | ||
|
||
The resource `ibm_kp_key` is deprecated and replaced with `ibm_kms_key`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be helpful to say when the deprecation started/took effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unfortunately, i dont know. But by my guesses it was over a year ago to 2 years ago
@hkantare could you help merge this PR? Need this one to make the next release |
"description": { | ||
Type: schema.TypeString, | ||
Optional: true, | ||
ForceNew: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change in description is forceNew?
We can't update description of the key?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is actually correct. Key Protect does not have a PATCH endpoint for keys.
Edit: we do, but it only supports changing keyRingID, but this functionality is something we have also not added to terraform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also if you look at the KMSKeyUpdate function it doesnt do anything really
Community Note
Changelog:
Relates OR Closes #0000
Output from acceptance testing:
This failure TestAccIBMKMSResource_Key_Alias_Key_Limit is due to a known bug
Only other failures are due to 429 rate limits and for resources we did not touch