Akamai authentication method upgraded #4700

yonatanyell · 2023-07-19T12:26:24Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

…2' into sm_validate_manual_dns_addition_2

…vider-ibm into akamai_authenticatino

yonatanyell · 2023-07-23T14:15:56Z

=== RUN TestAccIbmSmArbitrarySecretMetadataDataSourceBasic
--- PASS: TestAccIbmSmArbitrarySecretMetadataDataSourceBasic (23.46s)
=== RUN TestAccIbmSmArbitrarySecretDataSourceBasic
--- PASS: TestAccIbmSmArbitrarySecretDataSourceBasic (21.04s)
=== RUN TestAccIbmSmConfigurationsDataSourceBasic
--- PASS: TestAccIbmSmConfigurationsDataSourceBasic (35.63s)
=== RUN TestAccIbmSmEnRegistrationDataSourceBasic
--- PASS: TestAccIbmSmEnRegistrationDataSourceBasic (21.17s)
=== RUN TestAccIbmSmIamCredentialsConfigurationDataSourceBasic
--- PASS: TestAccIbmSmIamCredentialsConfigurationDataSourceBasic (24.04s)
=== RUN TestAccIbmSmIamCredentialsSecretMetadataDataSourceBasic
--- PASS: TestAccIbmSmIamCredentialsSecretMetadataDataSourceBasic (31.13s)
=== RUN TestAccIbmSmIamCredentialsSecretDataSourceBasic
--- PASS: TestAccIbmSmIamCredentialsSecretDataSourceBasic (30.55s)
=== RUN TestAccIbmSmImportedCertificateMetadataDataSourceBasic
--- PASS: TestAccIbmSmImportedCertificateMetadataDataSourceBasic (21.72s)
=== RUN TestAccIbmSmImportedCertificateDataSourceBasic
--- PASS: TestAccIbmSmImportedCertificateDataSourceBasic (21.71s)
=== RUN TestAccIbmSmKvSecretMetadataDataSourceBasic
--- PASS: TestAccIbmSmKvSecretMetadataDataSourceBasic (25.69s)
=== RUN TestAccIbmSmKvSecretDataSourceBasic
--- PASS: TestAccIbmSmKvSecretDataSourceBasic (21.06s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationIntermediateCADataSourceBasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationIntermediateCADataSourceBasic (27.24s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationRootCADataSourceBasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationRootCADataSourceBasic (21.65s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationTemplateDataSourceBasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationTemplateDataSourceBasic (27.86s)
=== RUN TestAccIbmSmPrivateCertificateMetadataDataSourceBasic
--- PASS: TestAccIbmSmPrivateCertificateMetadataDataSourceBasic (31.37s)
=== RUN TestAccIbmSmPrivateCertificateDataSourceBasic
--- PASS: TestAccIbmSmPrivateCertificateDataSourceBasic (32.00s)
=== RUN TestAccIbmSmPublicCertificateConfigurationCALetsEncryptDataSourceBasic
--- PASS: TestAccIbmSmPublicCertificateConfigurationCALetsEncryptDataSourceBasic (19.52s)
=== RUN TestAccIbmSmPublicCertificateConfigurationDnsCisDataSourceBasic
--- PASS: TestAccIbmSmPublicCertificateConfigurationDnsCisDataSourceBasic (20.31s)
=== RUN TestAccIbmSmPublicCertificateConfigurationDnsClassicInfrastructureDataSourceBasic
--- PASS: TestAccIbmSmPublicCertificateConfigurationDnsClassicInfrastructureDataSourceBasic (21.51s)
=== RUN TestAccIbmSmPublicCertificateMetadataDataSourceBasic
--- PASS: TestAccIbmSmPublicCertificateMetadataDataSourceBasic (151.34s)
=== RUN TestAccIbmSmPublicCertificateDataSourceBasic
--- PASS: TestAccIbmSmPublicCertificateDataSourceBasic (138.56s)
=== RUN TestAccIbmSmSecretGroupDataSourceBasic
--- PASS: TestAccIbmSmSecretGroupDataSourceBasic (21.56s)
=== RUN TestAccIbmSmSecretGroupDataSourceAllArgs
--- PASS: TestAccIbmSmSecretGroupDataSourceAllArgs (19.81s)
=== RUN TestAccIbmSmSecretGroupsDataSourceBasic
--- PASS: TestAccIbmSmSecretGroupsDataSourceBasic (21.67s)
=== RUN TestAccIbmSmSecretGroupsDataSourceAllArgs
--- PASS: TestAccIbmSmSecretGroupsDataSourceAllArgs (21.86s)
=== RUN TestAccIbmSmSecretsDataSourceBasic
--- PASS: TestAccIbmSmSecretsDataSourceBasic (25.92s)
=== RUN TestAccIbmSmUsernamePasswordSecretMetadataDataSourceBasic
--- PASS: TestAccIbmSmUsernamePasswordSecretMetadataDataSourceBasic (21.16s)
=== RUN TestAccIbmSmUsernamePasswordSecretDataSourceBasic
--- PASS: TestAccIbmSmUsernamePasswordSecretDataSourceBasic (22.30s)
=== RUN TestAccIbmSmArbitrarySecretBasic
--- PASS: TestAccIbmSmArbitrarySecretBasic (20.81s)
=== RUN TestAccIbmSmArbitrarySecretAllArgs
--- PASS: TestAccIbmSmArbitrarySecretAllArgs (38.93s)
=== RUN TestAccIbmSmEnRegistrationBasic
--- PASS: TestAccIbmSmEnRegistrationBasic (19.26s)
=== RUN TestAccIbmSmIamCredentialsConfigurationBasic
--- PASS: TestAccIbmSmIamCredentialsConfigurationBasic (24.46s)
=== RUN TestAccIbmSmIamCredentialsSecretBasic
--- PASS: TestAccIbmSmIamCredentialsSecretBasic (30.56s)
=== RUN TestAccIbmSmIamCredentialsSecretAllArgs
--- PASS: TestAccIbmSmIamCredentialsSecretAllArgs (45.30s)
=== RUN TestAccIbmSmImportedCertificateBasic
--- PASS: TestAccIbmSmImportedCertificateBasic (21.65s)
=== RUN TestAccIbmSmImportedCertificateAllArgs
--- PASS: TestAccIbmSmImportedCertificateAllArgs (40.38s)
=== RUN TestAccIbmSmKvSecretBasic
--- PASS: TestAccIbmSmKvSecretBasic (23.24s)
=== RUN TestAccIbmSmKvSecretAllArgs
--- PASS: TestAccIbmSmKvSecretAllArgs (40.56s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationActionSetSignedBasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationActionSetSignedBasic (21.42s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationActionSignCsrBasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationActionSignCsrBasic (22.16s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationIntermediateCABasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationIntermediateCABasic (26.41s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationIntermediateCAllArgs
--- PASS: TestAccIbmSmPrivateCertificateConfigurationIntermediateCAllArgs (42.54s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationRootCABasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationRootCABasic (20.73s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationRootCAllArgs
--- PASS: TestAccIbmSmPrivateCertificateConfigurationRootCAllArgs (36.65s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationTemplateBasic
--- PASS: TestAccIbmSmPrivateCertificateConfigurationTemplateBasic (28.04s)
=== RUN TestAccIbmSmPrivateCertificateConfigurationTemplateAllArgs
--- PASS: TestAccIbmSmPrivateCertificateConfigurationTemplateAllArgs (45.09s)
=== RUN TestAccIbmSmPrivateCertificateBasic
--- PASS: TestAccIbmSmPrivateCertificateBasic (35.68s)
=== RUN TestAccIbmSmPrivateCertificateAllArgs
--- PASS: TestAccIbmSmPrivateCertificateAllArgs (55.49s)
=== RUN TestAccIbmSmPublicCertificateActionValidateManualDnsBasic
--- PASS: TestAccIbmSmPublicCertificateActionValidateManualDnsBasic (394.64s)
=== RUN TestAccIbmSmPublicCertificateConfigurationCALetsEncryptBasic
--- PASS: TestAccIbmSmPublicCertificateConfigurationCALetsEncryptBasic (22.54s)
=== RUN TestAccIbmSmConfigurationPublicCertificateDnsCisBasic
--- PASS: TestAccIbmSmConfigurationPublicCertificateDnsCisBasic (21.10s)
=== RUN TestAccIbmSmPublicCertificateConfigurationDNSClassicInfrastructureBasic
--- PASS: TestAccIbmSmPublicCertificateConfigurationDNSClassicInfrastructureBasic (23.44s)
=== RUN TestAccIbmSmPublicCertificateBasic
--- PASS: TestAccIbmSmPublicCertificateBasic (149.62s)
=== RUN TestAccIbmSmPublicCertificateAllArgs
--- PASS: TestAccIbmSmPublicCertificateAllArgs (155.15s)
=== RUN TestAccIbmSmSecretGroupBasic
--- PASS: TestAccIbmSmSecretGroupBasic (31.11s)
=== RUN TestAccIbmSmSecretGroupAllArgs
--- PASS: TestAccIbmSmSecretGroupAllArgs (32.77s)
=== RUN TestAccIbmSmUsernamePasswordSecretBasic
--- PASS: TestAccIbmSmUsernamePasswordSecretBasic (21.82s)
=== RUN TestAccIbmSmUsernamePasswordSecretAllArgs
--- PASS: TestAccIbmSmUsernamePasswordSecretAllArgs (36.04s)
PASS
ok github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/secretsmanager 2452.125s

hkantare · 2023-07-25T08:39:21Z

ibm/service/secretsmanager/resource_ibm_sm_public_certificate.go

 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"edgerc": &schema.Schema{
-							Type:        schema.TypeString,
+							Type:        schema.TypeList,


This is breaking change . changing type will break exisiting users when they move to new verison

@hkantare this is a code from our previous PR that hasn’t been released yet, so no users will be affected

hkantare · 2023-07-25T08:40:31Z

ibm/service/secretsmanager/resource_ibm_sm_public_certificate.go

 						},
-						"config_section": &schema.Schema{


Follow the guidelines of Hashicorp when we want to deperectae/remove attributes

https://developer.hashicorp.com/terraform/plugin/sdkv2/best-practices/deprecations

@hkantare this is a code from our previous PR that hasn’t been released yet, so no users will be affected

* validate manual dns addition * validate manual dns * license added * upgraded akamai authentication * upgraded akamai authentication * upgraded akamai authentication --------- Co-authored-by: Yonathan-Yellin <[email protected]>

Yonathan-Yellin and others added 9 commits July 3, 2023 12:01

validate manual dns addition

45a8c5b

validate manual dns

9c8831c

Merge branch 'master' into sm_validate_manual_dns_addition_2

ee0bdf4

license added

dcec4e1

Merge remote-tracking branch 'origin/sm_validate_manual_dns_addition_…

37674e6

…2' into sm_validate_manual_dns_addition_2

Merge branch 'master' of https://github.com/yonatanyell/terraform-pro…

9d4bb0c

…vider-ibm into akamai_authenticatino

upgraded akamai authentication

30d8d79

upgraded akamai authentication

80b4226

upgraded akamai authentication

091545b

yonatanyell requested a review from hkantare July 19, 2023 14:03

yonatanyell added the service/Secrets Manager Issues related to Secrets Manager label Jul 19, 2023

hkantare reviewed Jul 25, 2023

View reviewed changes

hkantare approved these changes Jul 25, 2023

View reviewed changes

hkantare merged commit 5907420 into IBM-Cloud:master Jul 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Akamai authentication method upgraded #4700

Akamai authentication method upgraded #4700

yonatanyell commented Jul 19, 2023

yonatanyell commented Jul 23, 2023

hkantare Jul 25, 2023

yonatanyell Jul 25, 2023

hkantare Jul 25, 2023

hkantare Jul 25, 2023

yonatanyell Jul 25, 2023

Akamai authentication method upgraded #4700

Akamai authentication method upgraded #4700

Conversation

yonatanyell commented Jul 19, 2023

Community Note

yonatanyell commented Jul 23, 2023

hkantare Jul 25, 2023

Choose a reason for hiding this comment

yonatanyell Jul 25, 2023

Choose a reason for hiding this comment

hkantare Jul 25, 2023

Choose a reason for hiding this comment

hkantare Jul 25, 2023

Choose a reason for hiding this comment

yonatanyell Jul 25, 2023

Choose a reason for hiding this comment