You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request
Relates OR Closes #0000
Output from acceptance testing:
$ make testacc TESTARGS='-run=TestAccXXX'
...
Test:
=== RUN TestAccIBMPrivateDNSCustomResolverForwardingRulesDataSource_basic
--- PASS: TestAccIBMPrivateDNSCustomResolverForwardingRulesDataSource_basic (282.88s)
=== RUN TestAccIBMPrivateDNSCustomResolverDataSource_basic
--- PASS: TestAccIBMPrivateDNSCustomResolverDataSource_basic (258.72s)
=== RUN TestAccIBMPrivateDNSGlbMonitorsDataSource_basic
--- PASS: TestAccIBMPrivateDNSGlbMonitorsDataSource_basic (117.09s)
=== RUN TestAccIBMPrivateDNSGlbPoolsDataSource_basic
--- PASS: TestAccIBMPrivateDNSGlbPoolsDataSource_basic (182.49s)
=== RUN TestAccIBMPrivateDNSGlbLoadBalancersDataSource_basic
--- PASS: TestAccIBMPrivateDNSGlbLoadBalancersDataSource_basic (144.11s)
=== RUN TestAccIBMPrivateDNSNetworkDataSource_basic
--- PASS: TestAccIBMPrivateDNSNetworkDataSource_basic (81.00s)
=== RUN TestAccIBMPrivateDNSResourceRecordsDataSource_basic
--- PASS: TestAccIBMPrivateDNSResourceRecordsDataSource_basic (86.36s)
=== RUN TestAccIBMPrivateDNSCustomResolverSecondaryZonesDataSource_basic
--- PASS: TestAccIBMPrivateDNSCustomResolverSecondaryZonesDataSource_basic (256.57s)
=== RUN TestAccIBMPrivateDNSZonesDataSource_basic
--- PASS: TestAccIBMPrivateDNSZonesDataSource_basic (61.06s)
=== RUN TestAccIBMPrivateDNSCustomResolverForwardingRule_basic
--- PASS: TestAccIBMPrivateDNSCustomResolverForwardingRule_basic (249.83s)
=== RUN TestAccIBMPrivateDNSCustomResolverLocations_basic
--- PASS: TestAccIBMPrivateDNSCustomResolverLocations_basic (125.12s)
gahlaut-rahul
changed the title
Dns ut fix: strfmt to string conversion to fix broken UT
DNS ut fix: strfmt to string conversion to fix broken UT
Jul 5, 2023
)
* Enabled argument updated in docs for PDNS glb resource
* reverting the change made to main branch wrongly
* strfmt to string conversion to fix broken UT
* Wrongly left a debug msg, removing it
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gahlaut-rahul
changed the title
Community Note
Relates OR Closes #0000
Output from acceptance testing:
Test:
=== RUN TestAccIBMPrivateDNSCustomResolverForwardingRulesDataSource_basic
--- PASS: TestAccIBMPrivateDNSCustomResolverForwardingRulesDataSource_basic (282.88s)
=== RUN TestAccIBMPrivateDNSCustomResolverDataSource_basic
--- PASS: TestAccIBMPrivateDNSCustomResolverDataSource_basic (258.72s)
=== RUN TestAccIBMPrivateDNSGlbMonitorsDataSource_basic
--- PASS: TestAccIBMPrivateDNSGlbMonitorsDataSource_basic (117.09s)
=== RUN TestAccIBMPrivateDNSGlbPoolsDataSource_basic
--- PASS: TestAccIBMPrivateDNSGlbPoolsDataSource_basic (182.49s)
=== RUN TestAccIBMPrivateDNSGlbLoadBalancersDataSource_basic
--- PASS: TestAccIBMPrivateDNSGlbLoadBalancersDataSource_basic (144.11s)
=== RUN TestAccIBMPrivateDNSNetworkDataSource_basic
--- PASS: TestAccIBMPrivateDNSNetworkDataSource_basic (81.00s)
=== RUN TestAccIBMPrivateDNSResourceRecordsDataSource_basic
--- PASS: TestAccIBMPrivateDNSResourceRecordsDataSource_basic (86.36s)
=== RUN TestAccIBMPrivateDNSCustomResolverSecondaryZonesDataSource_basic
--- PASS: TestAccIBMPrivateDNSCustomResolverSecondaryZonesDataSource_basic (256.57s)
=== RUN TestAccIBMPrivateDNSZonesDataSource_basic
--- PASS: TestAccIBMPrivateDNSZonesDataSource_basic (61.06s)
=== RUN TestAccIBMPrivateDNSCustomResolverForwardingRule_basic
--- PASS: TestAccIBMPrivateDNSCustomResolverForwardingRule_basic (249.83s)
=== RUN TestAccIBMPrivateDNSCustomResolverLocations_basic
--- PASS: TestAccIBMPrivateDNSCustomResolverLocations_basic (125.12s)