Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove weak ciphers support from ike and ipsec policies #4584

Merged
merged 6 commits into from
May 30, 2023

Conversation

deepaksibm
Copy link
Contributor

Weak authentication algorithms md5 and sha1,
weak diffie hellman groups 2 and 5
and weak encryption algorithm triple_des were deprecated long and we added a note in the documentation mentioning the deprecation. https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/is_ike_policy
https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/is_ipsec_policy

Following the deprecation, the support is being removed now completely.

@deepaksibm deepaksibm marked this pull request as ready for review May 25, 2023 05:26
@deepaksibm
Copy link
Contributor Author


$ tfpt TestAccIBMISIKEPolicy_basic
=== RUN   TestAccIBMISIKEPolicy_basic
--- PASS: TestAccIBMISIKEPolicy_basic (86.92s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     88.489s

@hkantare hkantare merged commit a3853c9 into IBM-Cloud:master May 30, 2023
omaraibrahim pushed a commit to omaraibrahim/terraform-provider-ibm that referenced this pull request Jul 20, 2023
* removed the deprecated ciphers

* doc examples update

* keeping the validations so it doesn't break existing configurations

* corrected test case and updated pfs group value

* updated vpc sdk version
@deepaksibm deepaksibm deleted the remove-ciphers branch February 21, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants