Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed vmware: route priority #4435

Merged
merged 16 commits into from
Apr 14, 2023

Conversation

BShrivastav
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@BShrivastav
Copy link
Contributor Author

Screenshot 2023-03-27 at 9 46 10 AM

@BShrivastav BShrivastav force-pushed the managed-vmware-route-priority branch from ba2af3a to d1f936c Compare April 12, 2023 05:38
@hkantare
Copy link
Collaborator

@BShrivastav Can you please run exisiting testcases and share the results

@hkantare hkantare merged commit fd53546 into IBM-Cloud:master Apr 14, 2023
omaraibrahim pushed a commit to omaraibrahim/terraform-provider-ibm that referenced this pull request Jul 20, 2023
* added vmware route priority

* Update is_vpc_routing_table_route.html.markdown

* Update is_vpc_routing_table_route.html.markdown

* Update resource_ibm_is_vpc_routing_table_route.go

* Update resource_ibm_is_vpc_routing_table_route.go

* upd

* doc updates

* Update is_vpc_routing_table_route.html.markdown

* client level validation for the priority range.

* rebased

* updated priority range (0 to 4)

* rebased and updated sdk

* Updated usage from GetOk to GetOkExists

* sdk rebased

* review updates

* rebase and upstream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants