Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cloudant): handle capacity change duration more gracefully #4414

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

eiri
Copy link
Contributor

@eiri eiri commented Mar 16, 2023

Due to a throttling of capacity change operation on the back-end side it can take a number of hours to complete. This makes an instance creation operation for the instances requested with a large capacity to fail on a timeout even though the instance itself get provisioned.

This PR changes what parameters block we are using to report the capacity of the instance, allowing for the capacity change to catch up asynchronously.

This PR addresses an issue raised in #4356

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMCloudant'
[WARN] Set the environment variable IBM_APPID_TENANT_ID for testing AppID resources, AppID tests will fail if this is not set
...
[WARN] Set the environment variable IES_API_KEY for testing Event streams targets, the tests will fail if this is not set
=== RUN   TestAccIBMCloudantDatabaseDataSourceBasic
--- PASS: TestAccIBMCloudantDatabaseDataSourceBasic (78.23s)
=== RUN   TestAccIBMCloudantDataSource_basic
--- PASS: TestAccIBMCloudantDataSource_basic (93.71s)
=== RUN   TestAccIBMCloudantDatabaseBasic
--- PASS: TestAccIBMCloudantDatabaseBasic (106.84s)
=== RUN   TestAccIBMCloudantDatabaseAllArgs
--- PASS: TestAccIBMCloudantDatabaseAllArgs (111.71s)
=== RUN   TestAccIBMCloudant_basic
--- PASS: TestAccIBMCloudant_basic (117.63s)
=== RUN   TestAccIBMCloudant_import
--- PASS: TestAccIBMCloudant_import (156.72s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cloudant    665.785s

@kavya498
Copy link
Collaborator

@eiri ,
kindly resolve conflicts
Thanks

@eiri
Copy link
Contributor Author

eiri commented Mar 30, 2023

@kavya498 done, rebased over the current master.

@kavya498 kavya498 merged commit f9b657a into IBM-Cloud:master Mar 30, 2023
@eiri eiri deleted the update-set-capacity branch March 30, 2023 16:22
@emlaver
Copy link

emlaver commented May 2, 2023

Hello @kavya498 is this included in release v1.52.0? I'm not seeing it mentioned in the changelog

Nevermind, I see the change in 1.52.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants