Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Deprecate][ibm_dns_custom_resolver_location] : Retain schema and remove code #4296

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

sandeep645
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@sandeep645
Copy link
Contributor Author

Test result:

sandeeps@Sandeeps-MacBook-Pro custom_resolver % terraform apply --auto-approve

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # ibm_dns_custom_resolver_location.test1 will be created
  + resource "ibm_dns_custom_resolver_location" "test1" {
      + cr_enabled    = true
      + dns_server_ip = (known after apply)
      + enabled       = true
      + healthy       = (known after apply)
      + id            = (known after apply)
      + instance_id   = "7e546232-d8e2-4c7f-b2d6-982c686c2908"
      + location_id   = (known after apply)
      + resolver_id   = "c079479d-1f93-443b-934a-ff7db54a6326"
      + subnet_crn    = "crn:v1:staging:public:is:us-south-2:a/772989cf1fe0c64bbee8d0dd38ec5c71::subnet:0726-d0fbf337-d98d-443c-97c7-1915bdd320c5"
    }

Plan: 1 to add, 0 to change, 0 to destroy.
ibm_dns_custom_resolver_location.test1: Creating...
╷
│ Warning: Deprecated Resource
│
│   with ibm_dns_custom_resolver_location.test1,
│   on cr_spectrum_scale.tf line 50, in resource "ibm_dns_custom_resolver_location" "test1":
│   50: resource "ibm_dns_custom_resolver_location" "test1" {
│
│ Resource ibm_dns_custom_resolver_location is deprecated. Using the deprecated resource can cause an outage. If you have used the `ibm_dns_custom_resolver_location` resource, change it to the
│ composite Custom Resolver [ibm_dns_custom_resolver] resource before running terraform apply.
│
│ (and 2 more similar warnings elsewhere)
╵
╷
│ Error: Resource ibm_dns_custom_resolver_location is deprecated. Use the composite Custom Resolver resource[ibm_dns_custom_resolver], which can handle locations, instead.
│
│   with ibm_dns_custom_resolver_location.test1,
│   on cr_spectrum_scale.tf line 50, in resource "ibm_dns_custom_resolver_location" "test1":
│   50: resource "ibm_dns_custom_resolver_location" "test1" {
│
╵

Output from acceptance testing:

image

@hkantare hkantare merged commit fd4900e into IBM-Cloud:master Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants