Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(networkacl) : made name optional to allow create_before_destroy #4289

Merged
merged 1 commit into from
Jan 20, 2023
Merged

fix(networkacl) : made name optional to allow create_before_destroy #4289

merged 1 commit into from
Jan 20, 2023

Conversation

ujjwal-ibm
Copy link
Collaborator

@ujjwal-ibm ujjwal-ibm commented Jan 19, 2023 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestNetworkACLResourceGroupUpdate
--- PASS: TestNetworkACLResourceGroupUpdate (220.13s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     225.381s

@ujjwal-ibm
Copy link
Collaborator Author 

=== RUN   TestNetworkACLResourceGroupUpdate
--- PASS: TestNetworkACLResourceGroupUpdate (171.72s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     174.084s

@hkantare hkantare merged commit 36b6f3b into IBM-Cloud:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ujjwal-ibm @hkantare