Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single node infrastructure added #4269

Merged
merged 15 commits into from
Feb 1, 2023
Merged

Single node infrastructure added #4269

merged 15 commits into from
Feb 1, 2023

Conversation

cappetersson
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@cappetersson
Copy link
Contributor Author

@hkantare
Do you mind giving this PR a review? I appreciate it.

@cappetersson
Copy link
Contributor Author

@hkantare
Thank you for the inputs on my PR. I have gone through all of your comments and resolved them. Please let me know if there is anything I'm still missing.
Thank you

@hkantare
Copy link
Collaborator

Can you fix conflict in go.mod

@cappetersson
Copy link
Contributor Author

Output from TestAccSatelliteCluster_SingleNode

--- PASS: TestAccSatelliteCluster_SingleNode (5839.75s)

@hkantare, I've updated the repo based on your previous reviews and provided the output from the passing test. Ready for a review when you have a chance to take a look at it. Thanks.

@hkantare hkantare merged commit 0b50fb8 into IBM-Cloud:master Feb 1, 2023
adya1303 pushed a commit to adya1303/terraform-provider-ibm that referenced this pull request Feb 2, 2023
@cappetersson
Single node infrastructure added (IBM-Cloud#4269)
89ff10b 
* Single node infrastructure added

* Variable fix

* single-node code added

* Empty-Commit to run tests with updated sdk.

* Updated sdk version

* Added code for data recource

* Added documentation

* Added documentation

* Corrected typo

* Added test case for new variable

* Removed single-node resource. Added single-node parameters to existing create cluster resource.

* Changes reflecting PR comments.

* Added test case for single node clusters. Updated variables.

* Updated version
hkantare added a commit that referenced this pull request Feb 7, 2023
@ElliotG @briangleeson
@z0za @attilatabori @gmarjoram @deepaksibm @kavya498 @ujjwal-ibm @hkantare @alexhemard @benbuchanan @dependabot @Divya-Singh1693 @BShrivastav @cappetersson
Added new service Metrics Router to repo (#4246)
ff2926e 
* Added new service Metrics Router to repo

* Updated secret baseline file

* Updated baseline file with is_secret

* Changed sdk repo path

* Fixed a couple typos

Found a couple typos when I was deploying a cluster. This should fix it.

* Updates to tekton-pipeline support (#4235)

* fix(tekton): pos-GA updates

* chore(tekton): update Go SDK version

* fix(tekton): finalise tekton updates

Signed-off-by: Brian Gleeson <[email protected]>

* fix(tekton): Address Worker and href feedback

Signed-off-by: Brian Gleeson <[email protected]>

* add ForceNew tag to OS fields (#4279)

* add ForceNew tag to OS fileds, updated doc

* add forces new resource tag to the doc

Co-authored-by: Zoltan Illes <[email protected]>

* warning state in pending list, WARN logs about warning and critical s… (#4283)

* warning state in pending list, WARN logs about warning and critical states

* added extra clarification in docs about wait_till Normal option

* Continuous Delivery - Git PAT support (#4276)

* Git PAT support

* Fix example

* vpc address prefix and subnet doc fix

* Fix #4132: fix values_metadata argument in schematics resource

* enhancement(vpc-go-sdk) : Migration to latest 0.30.0

* fix(networkacl) : made name optional to allow create_before_destroy

* Remove certificate manager service support

* Fix ibm_appid_cloud_directory_user missing userName

* update provider metadata

* update CHANGELOG

* Bump up version to 1.50.0-beta0

* add optional secondary storage fields to IKS cluster and workerpool (#4255)

* add user defined secondary storage support to vpc cluster and workerpool

* tc fix for non secondarystorage case

* update docs and descriptions

* remove userdefined string, count and size is now integer in secondarystorage schema

* update docs

Co-authored-by: Zoltan Illes <[email protected]>

* CD: Field description updates for PAT

* refactor(Cloud Databases) autoscaling uses cloud-databases-go-sdk  (#4218)

* fix: documentation fix for ibm_cm_object resource

* dependabot: bump github/issue-labeler from 2.5 to 2.6

Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 2.5 to 2.6.
- [Release notes](https://github.com/github/issue-labeler/releases)
- [Commits](github/issue-labeler@v2.5...v2.6)

---
updated-dependencies:
- dependency-name: github/issue-labeler
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(tekton): bump Tekton Go SDK version

* dependabot: bump actions/checkout from 3.2.0 to 3.3.0

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.2.0...v3.3.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* update tags from globaltags to search API

* update metadata

* update CHANGELOG

* Bump up version to 1.50.0

* Adding new destination , integration and updating subscription resources for event notifications (#4321)

* adding new destination, updating email subscription and integrayion resources for event notification service

* Update go.mod

updating event notification package

* Update go.sum

updating event-notifications entry in go.sum

* Deprecate: retain schema and remove code

* Remove deprecated resource notification for VPC route resource (#4323)

* removal notification for vpc route

* updated the release number:

v1.51.0  - removal notification
v1.52.0 - resource is removed

* Single node infrastructure added (#4269)

* Single node infrastructure added

* Variable fix

* single-node code added

* Empty-Commit to run tests with updated sdk.

* Updated sdk version

* Added code for data recource

* Added documentation

* Added documentation

* Corrected typo

* Added test case for new variable

* Removed single-node resource. Added single-node parameters to existing create cluster resource.

* Changes reflecting PR comments.

* Added test case for single node clusters. Updated variables.

* Updated version

* fix: allow data to be set/updated when already unquoted

* refactor(Cloud Databases): configuration uses cloud-databases-go-sdk (#4234)

* refactor(Cloud Databases): configuration uses cloud-databases-go-sdk
* address PR comments
* remove unused bluemix client

---------

Signed-off-by: Brian Gleeson <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: ElliotG <[email protected]>
Co-authored-by: Brian Gleeson <[email protected]>
Co-authored-by: Zoltán Illés <[email protected]>
Co-authored-by: Zoltan Illes <[email protected]>
Co-authored-by: attilatabori <[email protected]>
Co-authored-by: gmarjoram <[email protected]>
Co-authored-by: Deepak Selvakumar <[email protected]>
Co-authored-by: hkavya26 <[email protected]>
Co-authored-by: Ujjwal Kumar <[email protected]>
Co-authored-by: hkantare <[email protected]>
Co-authored-by: alex hemard <[email protected]>
Co-authored-by: Ben Buchanan <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Divya-Singh1693 <[email protected]>
Co-authored-by: Sandeep S <[email protected]>
Co-authored-by: Bhavesh Shrivastav <[email protected]>
Co-authored-by: Carl Petersson <[email protected]>
hkantare added a commit that referenced this pull request Jun 15, 2023
@ElliotG @briangleeson
@z0za @attilatabori @gmarjoram @deepaksibm @kavya498 @ujjwal-ibm @hkantare @alexhemard @benbuchanan @dependabot @Divya-Singh1693 @BShrivastav @cappetersson
Added new service Metrics Router to terraform repo (#4337)
b5f08f5 
* Added new service Metrics Router to repo

* Updated secret baseline file

* Updated baseline file with is_secret

* Changed sdk repo path

* Fixed a couple typos

Found a couple typos when I was deploying a cluster. This should fix it.

* Updates to tekton-pipeline support (#4235)

* fix(tekton): pos-GA updates

* chore(tekton): update Go SDK version

* fix(tekton): finalise tekton updates

Signed-off-by: Brian Gleeson <[email protected]>

* fix(tekton): Address Worker and href feedback

Signed-off-by: Brian Gleeson <[email protected]>

* add ForceNew tag to OS fields (#4279)

* add ForceNew tag to OS fileds, updated doc

* add forces new resource tag to the doc

Co-authored-by: Zoltan Illes <[email protected]>

* warning state in pending list, WARN logs about warning and critical s… (#4283)

* warning state in pending list, WARN logs about warning and critical states

* added extra clarification in docs about wait_till Normal option

* Continuous Delivery - Git PAT support (#4276)

* Git PAT support

* Fix example

* vpc address prefix and subnet doc fix

* Fix #4132: fix values_metadata argument in schematics resource

* enhancement(vpc-go-sdk) : Migration to latest 0.30.0

* fix(networkacl) : made name optional to allow create_before_destroy

* Remove certificate manager service support

* Fix ibm_appid_cloud_directory_user missing userName

* update provider metadata

* update CHANGELOG

* Bump up version to 1.50.0-beta0

* add optional secondary storage fields to IKS cluster and workerpool (#4255)

* add user defined secondary storage support to vpc cluster and workerpool

* tc fix for non secondarystorage case

* update docs and descriptions

* remove userdefined string, count and size is now integer in secondarystorage schema

* update docs

Co-authored-by: Zoltan Illes <[email protected]>

* CD: Field description updates for PAT

* refactor(Cloud Databases) autoscaling uses cloud-databases-go-sdk  (#4218)

* fix: documentation fix for ibm_cm_object resource

* dependabot: bump github/issue-labeler from 2.5 to 2.6

Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 2.5 to 2.6.
- [Release notes](https://github.com/github/issue-labeler/releases)
- [Commits](github/issue-labeler@v2.5...v2.6)

---
updated-dependencies:
- dependency-name: github/issue-labeler
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(tekton): bump Tekton Go SDK version

* dependabot: bump actions/checkout from 3.2.0 to 3.3.0

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.2.0...v3.3.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* update tags from globaltags to search API

* update metadata

* update CHANGELOG

* Bump up version to 1.50.0

* Adding new destination , integration and updating subscription resources for event notifications (#4321)

* adding new destination, updating email subscription and integrayion resources for event notification service

* Update go.mod

updating event notification package

* Update go.sum

updating event-notifications entry in go.sum

* Deprecate: retain schema and remove code

* Remove deprecated resource notification for VPC route resource (#4323)

* removal notification for vpc route

* updated the release number:

v1.51.0  - removal notification
v1.52.0 - resource is removed

* Single node infrastructure added (#4269)

* Single node infrastructure added

* Variable fix

* single-node code added

* Empty-Commit to run tests with updated sdk.

* Updated sdk version

* Added code for data recource

* Added documentation

* Added documentation

* Corrected typo

* Added test case for new variable

* Removed single-node resource. Added single-node parameters to existing create cluster resource.

* Changes reflecting PR comments.

* Added test case for single node clusters. Updated variables.

* Updated version

* fix: allow data to be set/updated when already unquoted

* refactor(Cloud Databases): configuration uses cloud-databases-go-sdk (#4234)

* refactor(Cloud Databases): configuration uses cloud-databases-go-sdk
* address PR comments
* remove unused bluemix client

* Adopted new API changes

* updated .secrets.baseline

* fix formating provider.go

* Corrected the testing target CRN

* Modified the input table of content in README

* Added more examples

* minor changes in service names

* Picking mr gosdk from master

* Added info on settings id

* fixing issues

* Fix removal of permitted_target_regions

* Fix crashing issue due to empty targets

* Added info on first time setting of primary_metadata_region

* Added changes as per comments

---------

Signed-off-by: Brian Gleeson <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: ElliotG <[email protected]>
Co-authored-by: Brian Gleeson <[email protected]>
Co-authored-by: Zoltán Illés <[email protected]>
Co-authored-by: Zoltan Illes <[email protected]>
Co-authored-by: attilatabori <[email protected]>
Co-authored-by: gmarjoram <[email protected]>
Co-authored-by: Deepak Selvakumar <[email protected]>
Co-authored-by: hkavya26 <[email protected]>
Co-authored-by: Ujjwal Kumar <[email protected]>
Co-authored-by: hkantare <[email protected]>
Co-authored-by: alex hemard <[email protected]>
Co-authored-by: Ben Buchanan <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Divya-Singh1693 <[email protected]>
Co-authored-by: Sandeep S <[email protected]>
Co-authored-by: Bhavesh Shrivastav <[email protected]>
Co-authored-by: Carl Petersson <[email protected]>
omaraibrahim pushed a commit to omaraibrahim/terraform-provider-ibm that referenced this pull request Jul 20, 2023
@ElliotG @briangleeson
@z0za @attilatabori @gmarjoram @deepaksibm @kavya498 @ujjwal-ibm @hkantare @alexhemard @benbuchanan @dependabot @Divya-Singh1693 @BShrivastav @cappetersson @omaraibrahim
Added new service Metrics Router to terraform repo (IBM-Cloud#4337)
b5860fb 
* Added new service Metrics Router to repo

* Updated secret baseline file

* Updated baseline file with is_secret

* Changed sdk repo path

* Fixed a couple typos

Found a couple typos when I was deploying a cluster. This should fix it.

* Updates to tekton-pipeline support (IBM-Cloud#4235)

* fix(tekton): pos-GA updates

* chore(tekton): update Go SDK version

* fix(tekton): finalise tekton updates

Signed-off-by: Brian Gleeson <[email protected]>

* fix(tekton): Address Worker and href feedback

Signed-off-by: Brian Gleeson <[email protected]>

* add ForceNew tag to OS fields (IBM-Cloud#4279)

* add ForceNew tag to OS fileds, updated doc

* add forces new resource tag to the doc

Co-authored-by: Zoltan Illes <[email protected]>

* warning state in pending list, WARN logs about warning and critical s… (IBM-Cloud#4283)

* warning state in pending list, WARN logs about warning and critical states

* added extra clarification in docs about wait_till Normal option

* Continuous Delivery - Git PAT support (IBM-Cloud#4276)

* Git PAT support

* Fix example

* vpc address prefix and subnet doc fix

* Fix IBM-Cloud#4132: fix values_metadata argument in schematics resource

* enhancement(vpc-go-sdk) : Migration to latest 0.30.0

* fix(networkacl) : made name optional to allow create_before_destroy

* Remove certificate manager service support

* Fix ibm_appid_cloud_directory_user missing userName

* update provider metadata

* update CHANGELOG

* Bump up version to 1.50.0-beta0

* add optional secondary storage fields to IKS cluster and workerpool (IBM-Cloud#4255)

* add user defined secondary storage support to vpc cluster and workerpool

* tc fix for non secondarystorage case

* update docs and descriptions

* remove userdefined string, count and size is now integer in secondarystorage schema

* update docs

Co-authored-by: Zoltan Illes <[email protected]>

* CD: Field description updates for PAT

* refactor(Cloud Databases) autoscaling uses cloud-databases-go-sdk  (IBM-Cloud#4218)

* fix: documentation fix for ibm_cm_object resource

* dependabot: bump github/issue-labeler from 2.5 to 2.6

Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 2.5 to 2.6.
- [Release notes](https://github.com/github/issue-labeler/releases)
- [Commits](github/issue-labeler@v2.5...v2.6)

---
updated-dependencies:
- dependency-name: github/issue-labeler
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* chore(tekton): bump Tekton Go SDK version

* dependabot: bump actions/checkout from 3.2.0 to 3.3.0

Bumps [actions/checkout](https://github.com/actions/checkout) from 3.2.0 to 3.3.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3.2.0...v3.3.0)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* update tags from globaltags to search API

* update metadata

* update CHANGELOG

* Bump up version to 1.50.0

* Adding new destination , integration and updating subscription resources for event notifications (IBM-Cloud#4321)

* adding new destination, updating email subscription and integrayion resources for event notification service

* Update go.mod

updating event notification package

* Update go.sum

updating event-notifications entry in go.sum

* Deprecate: retain schema and remove code

* Remove deprecated resource notification for VPC route resource (IBM-Cloud#4323)

* removal notification for vpc route

* updated the release number:

v1.51.0  - removal notification
v1.52.0 - resource is removed

* Single node infrastructure added (IBM-Cloud#4269)

* Single node infrastructure added

* Variable fix

* single-node code added

* Empty-Commit to run tests with updated sdk.

* Updated sdk version

* Added code for data recource

* Added documentation

* Added documentation

* Corrected typo

* Added test case for new variable

* Removed single-node resource. Added single-node parameters to existing create cluster resource.

* Changes reflecting PR comments.

* Added test case for single node clusters. Updated variables.

* Updated version

* fix: allow data to be set/updated when already unquoted

* refactor(Cloud Databases): configuration uses cloud-databases-go-sdk (IBM-Cloud#4234)

* refactor(Cloud Databases): configuration uses cloud-databases-go-sdk
* address PR comments
* remove unused bluemix client

* Adopted new API changes

* updated .secrets.baseline

* fix formating provider.go

* Corrected the testing target CRN

* Modified the input table of content in README

* Added more examples

* minor changes in service names

* Picking mr gosdk from master

* Added info on settings id

* fixing issues

* Fix removal of permitted_target_regions

* Fix crashing issue due to empty targets

* Added info on first time setting of primary_metadata_region

* Added changes as per comments

---------

Signed-off-by: Brian Gleeson <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: ElliotG <[email protected]>
Co-authored-by: Brian Gleeson <[email protected]>
Co-authored-by: Zoltán Illés <[email protected]>
Co-authored-by: Zoltan Illes <[email protected]>
Co-authored-by: attilatabori <[email protected]>
Co-authored-by: gmarjoram <[email protected]>
Co-authored-by: Deepak Selvakumar <[email protected]>
Co-authored-by: hkavya26 <[email protected]>
Co-authored-by: Ujjwal Kumar <[email protected]>
Co-authored-by: hkantare <[email protected]>
Co-authored-by: alex hemard <[email protected]>
Co-authored-by: Ben Buchanan <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Divya-Singh1693 <[email protected]>
Co-authored-by: Sandeep S <[email protected]>
Co-authored-by: Bhavesh Shrivastav <[email protected]>
Co-authored-by: Carl Petersson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cappetersson @hkantare