fix: pass ibm cloud session token along to iaas #4254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwe
changed the title
Currently, in order to use the IBM provider to manager classic infrastructure resources you must either configure the provider manually with `iam_token` and `iam_refresh_token` variables, or you must provide api-specific credentials via the `iaas_classic_username` and `iaas_classic_api_key` variables. However, it should be reasonable when using `ibmcloud_api_key` for the provider to passthrough the access and refresh tokens received as part of the IBM Cloud session. It seemed like the original code had been in-place to do that, but it was incorrectly guarded by a non-nil check of `sess.SoftLayerSession.IAMToken` rather than a check to confirm that explicit iaas credentials hadn't been provided already. Signed-off-by: Dominic Evans <[email protected]>
dnwe
force-pushed
the
use-ibmcloud-session-for-softlayer-go
branch
from
fe92ce5
to
991293f
Compare
|
@hkantare is this something you could take a look at? I think you worked on the original IAM authentication flows |
|
@dnwe We will review and make it avilable as part of next release (Jan end) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in order to use the IBM provider to manager classic infrastructure resources you must either configure the provider manually with
iam_tokenandiam_refresh_tokenvariables, or you must provide api-specific credentials via theiaas_classic_usernameandiaas_classic_api_keyvariables. However, it should be reasonable when usingibmcloud_api_keyfor the provider to passthrough the access and refresh tokens received as part of the IBM Cloud session.It seemed like the original code had been in-place to do that, but it was incorrectly guarded by a non-nil check of
sess.SoftLayerSession.IAMTokenrather than a check to confirm that explicit iaas credentials hadn't been provided already.Community Note
Relates #3405