Additional CD Toolchain changes for GA

[gmarjoram]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

make testacc TEST=./ibm/service/cdtoolchain
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/cdtoolchain -v  -timeout 700m
=== RUN   TestAccIBMCdToolchainDataSourceBasic
--- PASS: TestAccIBMCdToolchainDataSourceBasic (27.09s)
=== RUN   TestAccIBMCdToolchainDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainDataSourceAllArgs (21.25s)
=== RUN   TestAccIBMCdToolchainToolAppconfigDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolAppconfigDataSourceBasic (33.37s)
=== RUN   TestAccIBMCdToolchainToolAppconfigDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolAppconfigDataSourceAllArgs (29.70s)
=== RUN   TestAccIBMCdToolchainToolArtifactoryDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolArtifactoryDataSourceBasic (25.15s)
=== RUN   TestAccIBMCdToolchainToolArtifactoryDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolArtifactoryDataSourceAllArgs (23.53s)
=== RUN   TestAccIBMCdToolchainToolBitbucketgitDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolBitbucketgitDataSourceBasic (25.53s)
=== RUN   TestAccIBMCdToolchainToolBitbucketgitDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolBitbucketgitDataSourceAllArgs (21.03s)
=== RUN   TestAccIBMCdToolchainToolCustomDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolCustomDataSourceBasic (25.28s)
=== RUN   TestAccIBMCdToolchainToolCustomDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolCustomDataSourceAllArgs (27.52s)
=== RUN   TestAccIBMCdToolchainToolDevopsinsightsDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolDevopsinsightsDataSourceBasic (24.90s)
=== RUN   TestAccIBMCdToolchainToolDevopsinsightsDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolDevopsinsightsDataSourceAllArgs (24.45s)
=== RUN   TestAccIBMCdToolchainToolGithubconsolidatedDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolGithubconsolidatedDataSourceBasic (22.14s)
=== RUN   TestAccIBMCdToolchainToolGithubconsolidatedDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolGithubconsolidatedDataSourceAllArgs (25.48s)
=== RUN   TestAccIBMCdToolchainToolGitlabDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolGitlabDataSourceBasic (25.88s)
=== RUN   TestAccIBMCdToolchainToolGitlabDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolGitlabDataSourceAllArgs (24.71s)
=== RUN   TestAccIBMCdToolchainToolHashicorpvaultDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolHashicorpvaultDataSourceBasic (29.55s)
=== RUN   TestAccIBMCdToolchainToolHashicorpvaultDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolHashicorpvaultDataSourceAllArgs (27.74s)
=== RUN   TestAccIBMCdToolchainToolHostedgitDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolHostedgitDataSourceBasic (27.13s)
=== RUN   TestAccIBMCdToolchainToolHostedgitDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolHostedgitDataSourceAllArgs (23.55s)
=== RUN   TestAccIBMCdToolchainToolJenkinsDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolJenkinsDataSourceBasic (24.34s)
=== RUN   TestAccIBMCdToolchainToolJenkinsDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolJenkinsDataSourceAllArgs (20.78s)
=== RUN   TestAccIBMCdToolchainToolJiraDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolJiraDataSourceBasic (25.17s)
=== RUN   TestAccIBMCdToolchainToolJiraDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolJiraDataSourceAllArgs (23.43s)
=== RUN   TestAccIBMCdToolchainToolKeyprotectDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolKeyprotectDataSourceBasic (25.04s)
=== RUN   TestAccIBMCdToolchainToolKeyprotectDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolKeyprotectDataSourceAllArgs (24.85s)
=== RUN   TestAccIBMCdToolchainToolNexusDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolNexusDataSourceBasic (22.94s)
=== RUN   TestAccIBMCdToolchainToolNexusDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolNexusDataSourceAllArgs (21.84s)
=== RUN   TestAccIBMCdToolchainToolPagerdutyDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolPagerdutyDataSourceBasic (19.86s)
=== RUN   TestAccIBMCdToolchainToolPagerdutyDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolPagerdutyDataSourceAllArgs (22.16s)
=== RUN   TestAccIBMCdToolchainToolPipelineDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolPipelineDataSourceBasic (25.57s)
=== RUN   TestAccIBMCdToolchainToolPipelineDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolPipelineDataSourceAllArgs (20.53s)
=== RUN   TestAccIBMCdToolchainToolPrivateworkerDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolPrivateworkerDataSourceBasic (22.07s)
=== RUN   TestAccIBMCdToolchainToolPrivateworkerDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolPrivateworkerDataSourceAllArgs (21.38s)
=== RUN   TestAccIBMCdToolchainToolSaucelabsDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolSaucelabsDataSourceBasic (23.95s)
=== RUN   TestAccIBMCdToolchainToolSaucelabsDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolSaucelabsDataSourceAllArgs (23.45s)
=== RUN   TestAccIBMCdToolchainToolSecretsmanagerDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolSecretsmanagerDataSourceBasic (21.85s)
=== RUN   TestAccIBMCdToolchainToolSecretsmanagerDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolSecretsmanagerDataSourceAllArgs (20.03s)
=== RUN   TestAccIBMCdToolchainToolSecuritycomplianceDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolSecuritycomplianceDataSourceBasic (19.41s)
=== RUN   TestAccIBMCdToolchainToolSecuritycomplianceDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolSecuritycomplianceDataSourceAllArgs (22.24s)
=== RUN   TestAccIBMCdToolchainToolSlackDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolSlackDataSourceBasic (25.54s)
=== RUN   TestAccIBMCdToolchainToolSlackDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolSlackDataSourceAllArgs (25.12s)
=== RUN   TestAccIBMCdToolchainToolSonarqubeDataSourceBasic
--- PASS: TestAccIBMCdToolchainToolSonarqubeDataSourceBasic (20.43s)
=== RUN   TestAccIBMCdToolchainToolSonarqubeDataSourceAllArgs
--- PASS: TestAccIBMCdToolchainToolSonarqubeDataSourceAllArgs (20.97s)
=== RUN   TestAccIBMCdToolchainBasic
--- PASS: TestAccIBMCdToolchainBasic (30.76s)
=== RUN   TestAccIBMCdToolchainAllArgs
--- PASS: TestAccIBMCdToolchainAllArgs (30.46s)
=== RUN   TestAccIBMCdToolchainToolAppconfigBasic
--- PASS: TestAccIBMCdToolchainToolAppconfigBasic (37.97s)
=== RUN   TestAccIBMCdToolchainToolAppconfigAllArgs
--- PASS: TestAccIBMCdToolchainToolAppconfigAllArgs (55.88s)
=== RUN   TestAccIBMCdToolchainToolArtifactoryBasic
--- PASS: TestAccIBMCdToolchainToolArtifactoryBasic (18.97s)
=== RUN   TestAccIBMCdToolchainToolArtifactoryAllArgs
--- PASS: TestAccIBMCdToolchainToolArtifactoryAllArgs (33.09s)
=== RUN   TestAccIBMCdToolchainToolBitbucketgitBasic
--- PASS: TestAccIBMCdToolchainToolBitbucketgitBasic (21.07s)
=== RUN   TestAccIBMCdToolchainToolBitbucketgitAllArgs
--- PASS: TestAccIBMCdToolchainToolBitbucketgitAllArgs (35.22s)
=== RUN   TestAccIBMCdToolchainToolCustomBasic
--- PASS: TestAccIBMCdToolchainToolCustomBasic (18.83s)
=== RUN   TestAccIBMCdToolchainToolCustomAllArgs
--- PASS: TestAccIBMCdToolchainToolCustomAllArgs (37.67s)
=== RUN   TestAccIBMCdToolchainToolDevopsinsightsBasic
--- PASS: TestAccIBMCdToolchainToolDevopsinsightsBasic (25.69s)
=== RUN   TestAccIBMCdToolchainToolDevopsinsightsAllArgs
--- PASS: TestAccIBMCdToolchainToolDevopsinsightsAllArgs (43.46s)
=== RUN   TestAccIBMCdToolchainToolGithubconsolidatedBasic
--- PASS: TestAccIBMCdToolchainToolGithubconsolidatedBasic (27.42s)
=== RUN   TestAccIBMCdToolchainToolGithubconsolidatedAllArgs
--- PASS: TestAccIBMCdToolchainToolGithubconsolidatedAllArgs (35.78s)
=== RUN   TestAccIBMCdToolchainToolGitlabBasic
--- PASS: TestAccIBMCdToolchainToolGitlabBasic (22.34s)
=== RUN   TestAccIBMCdToolchainToolGitlabAllArgs
--- PASS: TestAccIBMCdToolchainToolGitlabAllArgs (40.14s)
=== RUN   TestAccIBMCdToolchainToolHashicorpvaultBasic
--- PASS: TestAccIBMCdToolchainToolHashicorpvaultBasic (21.51s)
=== RUN   TestAccIBMCdToolchainToolHashicorpvaultAllArgs
--- PASS: TestAccIBMCdToolchainToolHashicorpvaultAllArgs (38.17s)
=== RUN   TestAccIBMCdToolchainToolHostedgitBasic
--- PASS: TestAccIBMCdToolchainToolHostedgitBasic (22.03s)
=== RUN   TestAccIBMCdToolchainToolHostedgitAllArgs
--- PASS: TestAccIBMCdToolchainToolHostedgitAllArgs (38.35s)
=== RUN   TestAccIBMCdToolchainToolJenkinsBasic
--- PASS: TestAccIBMCdToolchainToolJenkinsBasic (21.61s)
=== RUN   TestAccIBMCdToolchainToolJenkinsAllArgs
--- PASS: TestAccIBMCdToolchainToolJenkinsAllArgs (36.85s)
=== RUN   TestAccIBMCdToolchainToolJiraBasic
--- PASS: TestAccIBMCdToolchainToolJiraBasic (20.30s)
=== RUN   TestAccIBMCdToolchainToolJiraAllArgs
--- PASS: TestAccIBMCdToolchainToolJiraAllArgs (42.32s)
=== RUN   TestAccIBMCdToolchainToolKeyprotectBasic
--- PASS: TestAccIBMCdToolchainToolKeyprotectBasic (20.57s)
=== RUN   TestAccIBMCdToolchainToolKeyprotectAllArgs
--- PASS: TestAccIBMCdToolchainToolKeyprotectAllArgs (42.74s)
=== RUN   TestAccIBMCdToolchainToolNexusBasic
--- PASS: TestAccIBMCdToolchainToolNexusBasic (19.68s)
=== RUN   TestAccIBMCdToolchainToolNexusAllArgs
--- PASS: TestAccIBMCdToolchainToolNexusAllArgs (39.37s)
=== RUN   TestAccIBMCdToolchainToolPagerdutyBasic
--- PASS: TestAccIBMCdToolchainToolPagerdutyBasic (20.02s)
=== RUN   TestAccIBMCdToolchainToolPagerdutyAllArgs
--- PASS: TestAccIBMCdToolchainToolPagerdutyAllArgs (35.90s)
=== RUN   TestAccIBMCdToolchainToolPipelineBasic
--- PASS: TestAccIBMCdToolchainToolPipelineBasic (22.61s)
=== RUN   TestAccIBMCdToolchainToolPipelineAllArgs
--- PASS: TestAccIBMCdToolchainToolPipelineAllArgs (40.46s)
=== RUN   TestAccIBMCdToolchainToolPrivateworkerBasic
--- PASS: TestAccIBMCdToolchainToolPrivateworkerBasic (21.15s)
=== RUN   TestAccIBMCdToolchainToolPrivateworkerAllArgs
--- PASS: TestAccIBMCdToolchainToolPrivateworkerAllArgs (39.11s)
=== RUN   TestAccIBMCdToolchainToolSaucelabsBasic
--- PASS: TestAccIBMCdToolchainToolSaucelabsBasic (21.97s)
=== RUN   TestAccIBMCdToolchainToolSaucelabsAllArgs
--- PASS: TestAccIBMCdToolchainToolSaucelabsAllArgs (37.24s)
=== RUN   TestAccIBMCdToolchainToolSecretsmanagerBasic
--- PASS: TestAccIBMCdToolchainToolSecretsmanagerBasic (22.16s)
=== RUN   TestAccIBMCdToolchainToolSecretsmanagerAllArgs
--- PASS: TestAccIBMCdToolchainToolSecretsmanagerAllArgs (43.16s)
=== RUN   TestAccIBMCdToolchainToolSecuritycomplianceBasic
--- PASS: TestAccIBMCdToolchainToolSecuritycomplianceBasic (24.20s)
=== RUN   TestAccIBMCdToolchainToolSecuritycomplianceAllArgs
--- PASS: TestAccIBMCdToolchainToolSecuritycomplianceAllArgs (44.77s)
=== RUN   TestAccIBMCdToolchainToolSlackBasic
--- PASS: TestAccIBMCdToolchainToolSlackBasic (21.86s)
=== RUN   TestAccIBMCdToolchainToolSlackAllArgs
--- PASS: TestAccIBMCdToolchainToolSlackAllArgs (38.27s)
=== RUN   TestAccIBMCdToolchainToolSonarqubeBasic
--- PASS: TestAccIBMCdToolchainToolSonarqubeBasic (22.26s)
=== RUN   TestAccIBMCdToolchainToolSonarqubeAllArgs
--- PASS: TestAccIBMCdToolchainToolSonarqubeAllArgs (37.24s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cdtoolchain	2431.963s

make testacc TEST=./ibm/service/cdtektonpipeline TESTARGS=‘-run=TestAccIBMTekton*’
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/cdtektonpipeline -v ‘-run=TestAccIBMTekton*’ -timeout 700m
=== RUN   TestAccIBMCdTektonPipelineBasic
--- PASS: TestAccIBMCdTektonPipelineBasic (26.36s)
=== RUN   TestAccIBMCdTektonPipelineAllArgs
--- PASS: TestAccIBMCdTektonPipelineAllArgs (44.53s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/cdtektonpipeline	74.817s

[gmarjoram]

@hkantare this is ready for review/merge.
Mostly property description updates, and one property rename, thanks.