Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable cross account km #4128

Merged
merged 6 commits into from
Nov 3, 2022
Merged

Conversation

attilatabori
Copy link
Contributor

@attilatabori attilatabori commented Oct 27, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:


tabori@Attilas-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVpcClusterWorkerPoolKmsAccountEnvvar'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/kubernetes -v -run=TestAccIBMContainerVpcClusterWorkerPoolKmsAccountEnvvar -timeout 700m
[…]

2022-11-02T09:47:27.995+0100 [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccIBMContainerVpcClusterWorkerPoolKmsAccountEnvvar
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolKmsAccountEnvvar (710.07s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      711.239s

after remove of ImportStateVerifyIgnore

2022-11-02T12:34:20.825+0100 [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccIBMContainerVpcClusterWorkerPoolKmsAccountEnvvar
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolKmsAccountEnvvar (618.75s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      619.984s



tabori@Attilas-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVpcClusterEnvvar'      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/kubernetes -v -run=TestAccIBMContainerVpcClusterEnvvar -timeout 700m
[…]
022-11-02T10:29:37.021+0100 [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccIBMContainerVpcClusterEnvvar
--- PASS: TestAccIBMContainerVpcClusterEnvvar (2325.91s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      2326.969s





tabori@Attilas-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/kubernetes TESTARGS='-run=TestAccIBMContainerVPCClusterWorkerPoolDataSourceKmsAccountEnvvar'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/kubernetes -v -run=TestAccIBMContainerVPCClusterWorkerPoolDataSourceKmsAccountEnvvar -timeout 700m
[…]
2022-11-02T10:43:52.367+0100 [DEBUG] sdk.helper_resource: Finished TestCase: test_name=TestAccIBMContainerVPCClusterWorkerPoolDataSourceKmsAccountEnvvar
--- PASS: TestAccIBMContainerVPCClusterWorkerPoolDataSourceKmsAccountEnvvar (589.61s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      590.698s




...

@hkantare hkantare merged commit b44c380 into IBM-Cloud:master Nov 3, 2022
@hkantare hkantare mentioned this pull request Nov 3, 2022
hkantare pushed a commit that referenced this pull request Nov 8, 2022
* enable cross account km

* updates

* datasoure

* review updates

* removed ImportStateVerifyIgnore part
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants