Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc corrections for resource group to intimate id and subnet floating ip changes #4025

Merged
merged 4 commits into from
Sep 16, 2022

Conversation

BShrivastav
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@@ -43,7 +43,7 @@ In addition to all argument references listed, you can access the following attr
- `key_lifetime` - (Integer) The key lifetime in seconds.
- `name` - (String) The user-defined name for this IKE policy.
- `negotiation_mode` - (String) The IKE negotiation mode. Only `main` is supported.
- `resource_group` - (List) The resource group for this IKE policy.
- `resource_group` - (List) The resource group, for this IKE policy.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have same consistent

`resource_group` - (List) The resource group object,....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected from
resource_group - (List) The resource group,
to
resource_group - (List) The resource group object,....
across multiple files.

@@ -101,7 +103,7 @@ In addition to all argument reference list, you can access the following attribu

- `created_at` - (Timestamp) The date and time that the reserved IP was created.",
- `href` - (String) The URL for this reserved IP.
- `id` - (String) The combination of the subnet ID and reserved IP ID separated by **/**.
- `id` - (String) The combination of the subnet ID and reserved IP separated by **/**.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it not reserved IP ID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted.

@hkantare hkantare merged commit c3d43d1 into IBM-Cloud:master Sep 16, 2022
@ujjwal-ibm ujjwal-ibm deleted the bug-doc-fix-resource-grp-subnet branch September 17, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants