Added error output on failed bucket parsing #3757
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello. Not so long ago I encountered the same problem described in issue #2630. I think using bucket ID, instead of CRN, is not very intuitive for someone who has not read the documentation before importing. I suggest adding an error output that can be used in a search query to get a link to the documentation, issue and the answer in Stackoverflow.
Details
When I try to import the COS bucket, I get an error:
Steps for reproduce
terraform import <CRN>
command.Justification for PR
Now when you try to import a CRN, instead of an ID, you get an error:
I thought about using
$CRN:meta:$buckettype:$bucketlocation:$endpoint_type
, but sinceendpoint_type
is optional(public
by default), I decided not to add it.I also added a second check:
len(strings.Split(bucket_meta[1], ":")) < 2
, because without it you might get a stacktrace(example in Details) when trying to import$CRN:meta:
.Acceptance test