Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sshkey): add DiffSuppressFunc for public key for ibm_is_ssh_key resource #3701

Merged
merged 1 commit into from
Apr 11, 2022
Merged

fix(sshkey): add DiffSuppressFunc for public key for ibm_is_ssh_key resource #3701

merged 1 commit into from
Apr 11, 2022

Conversation

ujjwal-ibm
Copy link
Collaborator

@ujjwal-ibm ujjwal-ibm commented Apr 1, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #3639
Relates OR Closes #3751

Output from acceptance testing:

--- PASS: TestAccIBMISSSHKey_Newlinebasic (49.17s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     50.847s

--- PASS: TestAccIBMISSSHKey_basic (61.91s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     63.003s

@ujjwal-ibm ujjwal-ibm changed the title fix(sshkey): add DiffSuppressFunc for public key for in is_ssh_key resource fix(sshkey): add DiffSuppressFunc for public key for ibm_is_ssh_key resource Apr 1, 2022
@ujjwal-ibm
Copy link
Collaborator Author 

--- PASS: TestAccIBMISSSHKey_Newlinebasic (47.37s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     49.367s

--- PASS: TestAccIBMISSSHKey_basic (36.70s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     37.861s

@hkantare hkantare merged commit cf026a4 into IBM-Cloud:master Apr 11, 2022
@ujjwal-ibm ujjwal-ibm deleted the sshkey-fix branch April 14, 2022 07:11
@ujjwal-ibm ujjwal-ibm mentioned this pull request May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ibm_is_instance#keys changes key results in conflict re-apply tf ibm_is_ssh_key is not working as expected!
2 participants
@ujjwal-ibm @hkantare