Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power client update to refresh token for every API call #3614

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

yussufsh
Copy link
Collaborator

@yussufsh yussufsh commented Feb 24, 2022

Signed-off-by: Yussuf Shaikh [email protected]

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #3611

This PR upgrades the power-go-client sdk that will refresh token for every API call. Previously it was using same token for each client. The same client is passed to the waitFor* func which fails after 60m of time period.

Output from acceptance testing:

=== RUN   TestAccIBMPIInstanceBasic
--- PASS: TestAccIBMPIInstanceBasic (1121.00s)
=== RUN   TestAccIBMPIInstanceNetwork
--- PASS: TestAccIBMPIInstanceNetwork (1274.00s)
=== RUN   TestAccIBMPIInstanceMixedStorage
--- PASS: TestAccIBMPIInstanceMixedStorage (768.50s)

PASS

@yussufsh
Copy link
Collaborator Author

@hkantare @kavya498 can we fasttrack this commit to another beta version before the prod release? This is blocker where the instance provisioning takes more than 60 mins which is around 50% of times.

@yussufsh yussufsh added the service/Power Systems Issues related to Power Systems label Feb 24, 2022
@hkantare
Copy link
Collaborator

@yussufsh We have prod release on Monday we will port this PR

@hkantare hkantare merged commit ea0912f into IBM-Cloud:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Power Provisioning is failing with Token is expired
2 participants