Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor multiple pi resources with context awareness #3429

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

yussufsh
Copy link
Collaborator

@yussufsh yussufsh commented Dec 13, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

# data sources:
=== RUN   TestAccIBMPICatalogImagesDataSourceBasic
--- PASS: TestAccIBMPICatalogImagesDataSourceBasic (23.28s)
=== RUN   TestAccIBMPICatalogImagesDataSourceSAP
--- PASS: TestAccIBMPICatalogImagesDataSourceSAP (17.62s)
=== RUN   TestAccIBMPICatalogImagesDataSourceVTL
--- PASS: TestAccIBMPICatalogImagesDataSourceVTL (19.71s)
=== RUN   TestAccIBMPICatalogImagesDataSourceSAPAndVTL
--- PASS: TestAccIBMPICatalogImagesDataSourceSAPAndVTL (16.64s)
=== RUN   TestAccIBMPICloudConnectionDataSource_basic
--- PASS: TestAccIBMPICloudConnectionDataSource_basic (33.24s)
=== RUN   TestAccIBMPICloudConnectionsDataSourceBasic
--- PASS: TestAccIBMPICloudConnectionsDataSourceBasic (29.52s)
=== RUN   TestAccIBMPICloudInstanceDataSource_basic
--- PASS: TestAccIBMPICloudInstanceDataSource_basic (23.28s)
=== RUN   TestAccIBMPIDhcpDataSourceBasic
--- PASS: TestAccIBMPIDhcpDataSourceBasic (40.53s)
=== RUN   TestAccIBMPIDhcpServersDataSourceBasic
--- PASS: TestAccIBMPIDhcpServersDataSourceBasic (27.49s)
=== RUN   TestAccIBMPIImageDataSource_basic
--- PASS: TestAccIBMPIImageDataSource_basic (36.09s)
=== RUN   TestAccIBMPIImagesDataSource_basic
--- PASS: TestAccIBMPIImagesDataSource_basic (25.28s)
=== RUN   TestAccIBMPIInstanceIPDataSource_basic
--- PASS: TestAccIBMPIInstanceIPDataSource_basic (75.68s)
=== RUN   TestAccIBMPIInstanceDataSource_basic
--- PASS: TestAccIBMPIInstanceDataSource_basic (35.09s)
=== RUN   TestAccIBMPIVolumesDataSource_basic
--- PASS: TestAccIBMPIVolumesDataSource_basic (60.85s)
=== RUN   TestAccIBMPIKeyDataSource_basic
--- PASS: TestAccIBMPIKeyDataSource_basic (25.84s)
=== RUN   TestAccIBMPIKeysDataSourceBasic
--- PASS: TestAccIBMPIKeysDataSourceBasic (46.61s)
=== RUN   TestAccIBMPINetworkDataSource_basic
--- PASS: TestAccIBMPINetworkDataSource_basic (36.42s)
=== RUN   TestAccIBMPIPublicNetworkDataSource_basic
--- PASS: TestAccIBMPIPublicNetworkDataSource_basic (21.19s)
=== RUN   TestAccIBMPISAPProfileDataSourceBasic
--- PASS: TestAccIBMPISAPProfileDataSourceBasic (24.17s)
=== RUN   TestAccIBMPISAPProfilesDataSourceBasic
--- PASS: TestAccIBMPISAPProfilesDataSourceBasic (35.75s)
=== RUN   TestAccIBMPISnapshotDataSource_basic
=== RUN   TestAccIBMPITenantDataSource_basic
--- PASS: TestAccIBMPITenantDataSource_basic (44.59s)
=== RUN   TestAccIBMPIVolumeDataSource_basic
--- PASS: TestAccIBMPIVolumeDataSource_basic (39.81s)
=== RUN   TestAccIBMPIInstanceConsoleLanguages
--- PASS: TestAccIBMPIInstanceConsoleLanguages (70.88s)
PASS

#resources:
=== RUN   TestAccIBMPIDhcpbasic
--- PASS: TestAccIBMPIDhcpbasic (514.43s)
=== RUN   TestAccIBMPIImagebasic
--- PASS: TestAccIBMPIImagebasic (157.59s)
=== RUN   TestAccIBMPIImageCOSPublicImport
--- PASS: TestAccIBMPIImageCOSPublicImport (1090.90s)
=== RUN   TestAccIBMPIInstanceBasic
--- PASS: TestAccIBMPIInstanceBasic (1003.88s)
=== RUN   TestAccIBMPINetworkPortbasic
--- PASS: TestAccIBMPINetworkPortbasic (70.95s)
=== RUN   TestAccIBMPINetworkbasic
--- PASS: TestAccIBMPINetworkbasic (57.91s)
=== RUN   TestAccIBMPIInstanceSnapshotbasic
--- PASS: TestAccIBMPIInstanceSnapshotbasic (727.89s)
=== RUN   TestAccIBMPIKey_basic
--- PASS: TestAccIBMPIKey_basic (30.60s)
=== RUN   TestAccIBMPIVolumebasic
--- PASS: TestAccIBMPIVolumebasic (105.32s)
=== RUN   TestAccIBMPIVolumePool
--- PASS: TestAccIBMPIVolumePool (74.14s)
=== RUN   TestAccIBMPIIPSecPolicyBasic
--- PASS: TestAccIBMPIIPSecPolicyBasic (67.97s)
=== RUN   TestAccIBMPIKey_basic
--- PASS: TestAccIBMPIKey_basic (33.98s)
=== RUN   TestAccIBMPIVPNConnectionBasic
--- PASS: TestAccIBMPIVPNConnectionBasic (600.58s)
=== RUN   TestAccIBMPIInstanceConsoleLanguage
--- PASS: TestAccIBMPIInstanceConsoleLanguage (84.24s)
PASS
...

@yussufsh
Copy link
Collaborator Author

Sorry for a huge change set but I am revamping the whole power client project.
@hkantare Kindly help with the review.

@hkantare
Copy link
Collaborator

@yussufsh Can we seperate new set of reosurces/datasource from this PR

Can fix the conflicts

@yussufsh
Copy link
Collaborator Author

@yussufsh Can we seperate new set of reosurces/datasource from this PR

Can fix the conflicts

I have removed the top two commits and will create individual PRs for them once this is merged. @hkantare PTAL again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants