Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: sdk migration to use 0.14.0 version of vpc-go-sdk #3376

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

ujjwal-ibm
Copy link
Collaborator

@ujjwal-ibm ujjwal-ibm commented Nov 30, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

--- PASS: TestAccIBMISSSHKeyDatasource_basic (54.68s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 58.873s
--- PASS: TestAccIBMISVPNGatewayConnection_basic (920.64s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 925.649s
--- PASS: TestAccIBMISVPNGatewayConnection_route (566.93s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 571.675s

@kavya498
Copy link
Collaborator

kavya498 commented Nov 30, 2021

@ujjwal-ibm ,

  1. Can you please attach test results of data_source_ibm_is_ssh_key and resource_ibm_is_vpn_gateway_connections?
  2. Since there is SDK change did you make sure that it is not breaking any existing resources? @astha-jain FYI
  3. Please reduce number of commits to 1

Thanks

@hkantare hkantare merged commit 13bf96c into IBM-Cloud:master Dec 2, 2021
@ujjwal-ibm ujjwal-ibm deleted the migration-0.14-vpc-go-sdk branch December 2, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants