Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added filters to snapshot collection datasource #3238

Merged
merged 1 commit into from
Dec 6, 2021
Merged

added filters to snapshot collection datasource #3238

merged 1 commit into from
Dec 6, 2021

Conversation

ujjwal-ibm
Copy link
Collaborator

@ujjwal-ibm ujjwal-ibm commented Oct 21, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMISSnapshotsDatasource_basic
no message sent
no message sent
no message sent
--- PASS: TestAccIBMISSnapshotsDatasource_basic (325.54s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 329.430s

astha-jain
astha-jain reviewed Nov 9, 2021
View reviewed changes
Copy link
Contributor

@astha-jain astha-jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good. Can you add some tests for the filters?

astha-jain
astha-jain approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@astha-jain astha-jain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hkantare hkantare merged commit 165c783 into IBM-Cloud:master Dec 6, 2021
@ujjwal-ibm ujjwal-ibm deleted the snapshots-ds-filters branch January 4, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astha-jain astha-jain astha-jain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ujjwal-ibm @astha-jain @hkantare