Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: instance bandwidth #3156

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Feature: instance bandwidth #3156

merged 1 commit into from
Nov 9, 2021

Conversation

deepaksibm
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@hkantare
Copy link
Collaborator

hkantare commented Nov 2, 2021

Please update the testcas results for all changed reosurces/datasources

hkantare
hkantare reviewed Nov 2, 2021
View reviewed changes
ibm/resource_ibm_is_instance_template.go Outdated
isInstanceTotalVolumeBandwidth: {
Type: schema.TypeInt,
Optional: true,
Computed: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we support update on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not support updated on this, so i have added ForceNew True.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have removed computed and kept only forcenew and optional

website/docs/d/is_instance_profile.html.markdown Outdated Show resolved Hide resolved
website/docs/d/is_instance_profiles.html.markdown Outdated Show resolved Hide resolved
website/docs/d/is_instances.html.markdown Outdated Show resolved Hide resolved
website/docs/d/is_volume.html.markdown Show resolved Hide resolved
website/docs/r/is_instance.html.markdown Outdated Show resolved Hide resolved
website/docs/r/is_volume.html.markdown Outdated Show resolved Hide resolved
@astha-jain
Copy link
Contributor

Closes #3292

@hkantare
Copy link
Collaborator

hkantare commented Nov 8, 2021

@deepaksibm Can you please look into review comments

@deepaksibm deepaksibm force-pushed the feature-is-instance-bandwith branch 2 times, most recently from 167d9ac to 6c5bbf6 Compare November 8, 2021 08:21
@deepaksibm
Copy link
Contributor Author

deepaksibm commented Nov 8, 2021 •
edited
Loading 

$ make testacc TEST=./ibm  TESTARGS='-run=TestAccIBMISInstanceBandwidth_basic'
=== RUN   TestAccIBMISInstanceBandwidth_basic
no message sent
no message sent
no message sent
no message sent
--- PASS: TestAccIBMISInstanceBandwidth_basic (261.57s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 264.179s

$ make testacc TEST=./ibm  TESTARGS='-run=TestAccIBMISInstance_basic' 
=== RUN   TestAccIBMISInstance_basic
no message sent
no message sent
no message sent
no message sent
--- PASS: TestAccIBMISInstance_basic (218.23s)
=== RUN   TestAccIBMISInstance_basicwithipv4
no message sent
no message sent
no message sent
--- PASS: TestAccIBMISInstance_basicwithipv4 (202.99s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 424.078s

$ make testacc TEST=./ibm  TESTARGS='-run=TestAccIBMISInstanceTemplate_basic'
=== RUN   TestAccIBMISInstanceTemplate_basic
--- PASS: TestAccIBMISInstanceTemplate_basic (120.42s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 122.879s

$ make testacc TEST=./ibm  TESTARGS='-run=TestAccIBMISInstanceProfileDataSource_basic'
=== RUN   TestAccIBMISInstanceProfileDataSource_basic
--- PASS: TestAccIBMISInstanceProfileDataSource_basic (23.61s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 25.894s

$ make testacc TEST=./ibm  TESTARGS='-run=TestAccIBMISInstanceProfilesDataSource_basic'
=== RUN   TestAccIBMISInstanceProfilesDataSource_basic
--- PASS: TestAccIBMISInstanceProfilesDataSource_basic (31.76s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 34.188s

$ make testacc TEST=./ibm  TESTARGS='-run=TestAccIBMISInstanceTemplate_dataBasic'
=== RUN   TestAccIBMISInstanceTemplate_dataBasic
--- PASS: TestAccIBMISInstanceTemplate_dataBasic (129.94s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 132.196s

$ make testacc TEST=./ibm  TESTARGS='-run=TestAccIBMISInstanceTemplates_dataBasic'
=== RUN   TestAccIBMISInstanceTemplates_dataBasic
--- PASS: TestAccIBMISInstanceTemplates_dataBasic (127.30s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 129.893s

$ make testacc TEST=./ibm  TESTARGS='-run=TestAccIBMISInstancesDataSource_basic'
=== RUN   TestAccIBMISInstancesDataSource_basic
no message sent
no message sent
no message sent
no message sent
--- PASS: TestAccIBMISInstancesDataSource_basic (260.26s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm 262.738s

@deepaksibm
Copy link
Contributor Author

@deepaksibm Can you please look into review comments

@hkantare Have addressed the review comments

@hkantare hkantare merged commit ed9cb29 into IBM-Cloud:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepaksibm @hkantare @astha-jain