Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delete topic does not fail when topic does not exist #2976

Merged
merged 3 commits into from
Aug 17, 2021
Merged

fix: delete topic does not fail when topic does not exist #2976

merged 3 commits into from
Aug 17, 2021

Conversation

JunliWang
Copy link
Contributor

the issue is:
https://ibm-cloudplatform.slack.com/archives/C53NF5MB4/p1628689859157700

the fix includes:

  1. increase the default timeout from 3s to 30s
  2. when topic does not exist, consider topic deletion is successful
  3. bump dependencies(sarama) and broker version from 2.3 to 2.6

@JunliWang JunliWang changed the title delete topic does not fail when topic does not exists fix: delete topic does not fail when topic does not exists Aug 11, 2021
@JunliWang JunliWang changed the title fix: delete topic does not fail when topic does not exists fix: delete topic does not fail when topic does not exist Aug 12, 2021
@hkantare
Copy link
Collaborator

Can you please resolve the conflicts in go.sum

@hkantare hkantare merged commit 749256f into IBM-Cloud:master Aug 17, 2021
hkantare pushed a commit that referenced this pull request Aug 18, 2021
* delete topic does not fail when topic does not exists

* update deps
hkantare pushed a commit that referenced this pull request Sep 1, 2021
* fix: delete topic does not fail when topic does not exist (#2976)

* delete topic does not fail when topic does not exists

* update deps

* remove kms_key_policy.html.markdown

Co-authored-by: Junli Wang <[email protected]>
Co-authored-by: Harshit-Gupta2 <[email protected]>
hkantare pushed a commit that referenced this pull request Sep 3, 2021
* fix: delete topic does not fail when topic does not exist (#2976)

* delete topic does not fail when topic does not exists

* update deps

* remove kms_key_policy.html.markdown

Co-authored-by: Junli Wang <[email protected]>
Co-authored-by: Harshit-Gupta2 <[email protected]>
kavya498 pushed a commit to kavya498/terraform-provider-ibm that referenced this pull request Sep 30, 2021
…2976)

* delete topic does not fail when topic does not exists

* update deps
kavya498 pushed a commit to kavya498/terraform-provider-ibm that referenced this pull request Sep 30, 2021
…2976)

* delete topic does not fail when topic does not exists

* update deps
kavya498 pushed a commit to kavya498/terraform-provider-ibm that referenced this pull request Sep 30, 2021
* fix: delete topic does not fail when topic does not exist (IBM-Cloud#2976)

* delete topic does not fail when topic does not exists

* update deps

* remove kms_key_policy.html.markdown

Co-authored-by: Junli Wang <[email protected]>
Co-authored-by: Harshit-Gupta2 <[email protected]>
kavya498 pushed a commit to kavya498/terraform-provider-ibm that referenced this pull request Sep 30, 2021
* fix: delete topic does not fail when topic does not exist (IBM-Cloud#2976)

* delete topic does not fail when topic does not exists

* update deps

* remove kms_key_policy.html.markdown

Co-authored-by: Junli Wang <[email protected]>
Co-authored-by: Harshit-Gupta2 <[email protected]>
kavya498 pushed a commit to kavya498/terraform-provider-ibm that referenced this pull request Sep 30, 2021
…2976)

* delete topic does not fail when topic does not exists

* update deps
kavya498 pushed a commit to kavya498/terraform-provider-ibm that referenced this pull request Sep 30, 2021
…2976)

* delete topic does not fail when topic does not exists

* update deps
kavya498 pushed a commit to kavya498/terraform-provider-ibm that referenced this pull request Sep 30, 2021
* fix: delete topic does not fail when topic does not exist (IBM-Cloud#2976)

* delete topic does not fail when topic does not exists

* update deps

* remove kms_key_policy.html.markdown

Co-authored-by: Junli Wang <[email protected]>
Co-authored-by: Harshit-Gupta2 <[email protected]>
kavya498 pushed a commit to kavya498/terraform-provider-ibm that referenced this pull request Sep 30, 2021
* fix: delete topic does not fail when topic does not exist (IBM-Cloud#2976)

* delete topic does not fail when topic does not exists

* update deps

* remove kms_key_policy.html.markdown

Co-authored-by: Junli Wang <[email protected]>
Co-authored-by: Harshit-Gupta2 <[email protected]>
hkantare pushed a commit that referenced this pull request Dec 2, 2021
* fix: delete topic does not fail when topic does not exist (#2976)

* delete topic does not fail when topic does not exists

* update deps

* fix: delete topic does not fail when topic does not exist (#2976)

* delete topic does not fail when topic does not exists

* update deps

* Docs changed for maintaning consistency

Co-authored-by: Junli Wang <[email protected]>
Co-authored-by: Harshit-Gupta2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants