Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging not supported for Network Loadbalancer #2332

Merged
merged 2 commits into from
Mar 11, 2021
Merged

Logging not supported for Network Loadbalancer #2332

merged 2 commits into from
Mar 11, 2021

Conversation

SunithaGudisagarIBM
Copy link
Collaborator

@SunithaGudisagarIBM SunithaGudisagarIBM commented Mar 10, 2021

Screenshot 2021-03-10 at 2 12 47 PM

![Uploading Screenshot 2021-03-10 at 2.15.46 PM.png…]()

Screenshot 2021-03-10 at 2 20 56 PM

Screenshot 2021-03-10 at 2 29 54 PM

Screenshot 2021-03-10 at 2 52 58 PM

@@ -501,6 +508,16 @@ func lbGet(d *schema.ResourceData, meta interface{}, id string) error {
if profile.Name != nil {
d.Set(isLBProfile, *lb.Profile.Name)
}
} else {
if lb.Logging != nil {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you can have only 1 if condition if lb.logging != nil && lb.logging.Datapath != nil &&l b.logging.Datapath.Active != nil

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hkantare Changes Incorporated

@hkantare hkantare merged commit 2cbc343 into IBM-Cloud:master Mar 11, 2021
@SunithaGudisagarIBM SunithaGudisagarIBM deleted the bug/networklb branch March 11, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants