Q3 Release 2024

clients/instance/ibm-pi-snapshot.go

@@ -8,6 +8,8 @@ import (
 	"github.com/IBM-Cloud/power-go-client/ibmpisession"
 	"github.com/IBM-Cloud/power-go-client/power/client/p_cloud_p_vm_instances"
 	"github.com/IBM-Cloud/power-go-client/power/client/p_cloud_snapshots"
+	"github.com/IBM-Cloud/power-go-client/power/client/snapshots"
+
 	"github.com/IBM-Cloud/power-go-client/power/models"
 )
 
@@ -96,3 +98,59 @@ func (f *IBMPISnapshotClient) Create(instanceID, snapshotID, restoreFailAction s
 	}
 	return resp.Payload, nil
 }
+
+// Get a Volume SnapshotV1
+func (f *IBMPISnapshotClient) V1VolumeSnapshotsGet(id string) (*models.SnapshotV1, error) {
+	params := snapshots.NewV1VolumeSnapshotsGetParams().WithContext(f.ctx).WithTimeout(helpers.PIGetTimeOut).WithVolumeSnapshotUUID(id)
+	resp, err := f.session.Power.Snapshots.V1VolumeSnapshotsGet(params, f.session.AuthInfo(f.cloudInstanceID))
+
+	if err != nil {
+		return nil, ibmpisession.SDKFailWithAPIError(err, fmt.Errorf("failed to Get volume snapshot %s: %w", id, err))
+	}
+	if resp == nil || resp.Payload == nil {
+		return nil, fmt.Errorf("failed to Get PI Snapshot %s", id)
+	}
+	return resp.Payload, nil
+}
+
+// Get Volume All SnapshotsV1
+func (f *IBMPISnapshotClient) V1VolumeSnapshotsGetall() (*models.VolumeSnapshotList, error) {
+	params := snapshots.NewV1VolumeSnapshotsGetallParams().WithContext(f.ctx).WithTimeout(helpers.PIGetTimeOut)
+	resp, err := f.session.Power.Snapshots.V1VolumeSnapshotsGetall(params, f.session.AuthInfo(f.cloudInstanceID))
+
+	if err != nil {
+		return nil, ibmpisession.SDKFailWithAPIError(err, fmt.Errorf("failed to Get all volume snapshots: %w", err))
+	}
+	if resp == nil || resp.Payload == nil {
+		return nil, fmt.Errorf("failed to Get all volume Snapshots")
+	}
+	return resp.Payload, nil
+}
+
+// Deprecated Get a SnapshotV1
+func (f *IBMPISnapshotClient) V1SnapshotsGet(id string) (*models.SnapshotV1, error) {
+	params := snapshots.NewV1SnapshotsGetParams().WithContext(f.ctx).WithTimeout(helpers.PIGetTimeOut).WithSnapshotID(id)
+	resp, err := f.session.Power.Snapshots.V1SnapshotsGet(params, f.session.AuthInfo(f.cloudInstanceID))
+
+	if err != nil {
+		return nil, ibmpisession.SDKFailWithAPIError(err, fmt.Errorf("failed to Get PI Snapshot %s: %w", id, err))
+	}
+	if resp == nil || resp.Payload == nil {
+		return nil, fmt.Errorf("failed to Get PI Snapshot %s", id)
+	}
+	return resp.Payload, nil
+}
+
+// Deprecated Get All SnapshotsV1
+func (f *IBMPISnapshotClient) V1SnapshotsGetall() (*models.SnapshotList, error) {
+	params := snapshots.NewV1SnapshotsGetallParams().WithContext(f.ctx).WithTimeout(helpers.PIGetTimeOut)
+	resp, err := f.session.Power.Snapshots.V1SnapshotsGetall(params, f.session.AuthInfo(f.cloudInstanceID))
+
+	if err != nil {
+		return nil, ibmpisession.SDKFailWithAPIError(err, fmt.Errorf("failed to Get all PI Snapshots: %w", err))
+	}
+	if resp == nil || resp.Payload == nil {
+		return nil, fmt.Errorf("failed to Get all PI Snapshots")
+	}
+	return resp.Payload, nil
+}

clients/instance/ibm-pi-volume.go

@@ -257,34 +257,12 @@ func (f *IBMPIVolumeClient) GetVolumeFlashCopyMappings(id string) (models.FlashC
 
 // Bulk volume detach
 func (f *IBMPIVolumeClient) BulkVolumeDetach(pvmID string, body *models.VolumesDetach) (*models.VolumesDetachmentResponse, error) {
-	params := p_cloud_volumes.NewPcloudV2PvminstancesVolumesDeleteParams().
-		WithContext(f.ctx).WithTimeout(helpers.PIDeleteTimeOut).WithCloudInstanceID(f.cloudInstanceID).WithPvmInstanceID(pvmID).
-		WithBody(body)
-	resp, err := f.session.Power.PCloudVolumes.PcloudV2PvminstancesVolumesDelete(params, f.session.AuthInfo(f.cloudInstanceID))
-	if err != nil {
-		return nil, ibmpisession.SDKFailWithAPIError(err, fmt.Errorf(errors.DetachVolumesOperationFailed, pvmID, f.cloudInstanceID, err))
-	}
-	if resp == nil || resp.Payload == nil {
-		return nil, fmt.Errorf("failed detaching volumes for %s", pvmID)
-	}
-	return resp.Payload, nil
+	return nil, fmt.Errorf("operation not supported")
 }
 
 // Bulk volume delete
 func (f *IBMPIVolumeClient) BulkVolumeDelete(body *models.VolumesDelete) (*models.VolumesDeleteResponse, error) {
-	params := p_cloud_volumes.NewPcloudV2VolumesDeleteParams().WithContext(f.ctx).WithTimeout(helpers.PIDeleteTimeOut).
-		WithCloudInstanceID(f.cloudInstanceID).WithBody(body)
-	respOk, respPartial, err := f.session.Power.PCloudVolumes.PcloudV2VolumesDelete(params, f.session.AuthInfo(f.cloudInstanceID))
-	if err != nil {
-		return nil, ibmpisession.SDKFailWithAPIError(err, fmt.Errorf(errors.DeleteVolumeOperationFailed, body.VolumeIDs, err))
-	}
-	if respOk != nil && respOk.Payload != nil {
-		return respOk.Payload, nil
-	}
-	if respPartial != nil && respPartial.Payload != nil {
-		return respPartial.Payload, nil
-	}
-	return nil, fmt.Errorf("failed Deleting volumes : %s", body.VolumeIDs)
+	return nil, fmt.Errorf("operation not supported")
 }
 
 // Bulk volutme attach

examples/snapshot/main.go

@@ -24,6 +24,7 @@ func main() {
 	instance_id := " < INSTANCE ID > "
 	snap_name := " < SNAPSHOT NAME > "
 	description := " < DESCRIPTION > "
+	snapshot_id := " < SNAPSHOT ID > "
 
 	authenticator := &core.BearerTokenAuthenticator{
 		BearerToken: token,
@@ -81,4 +82,16 @@ func main() {
 	}
 	log.Printf("***************[4]****************** %+v \n", err)
 
+	// ***************[] SnapshotsV1 []******************
+	getAllSnapV1Resp, err := powerSnapClient.V1SnapshotsGetall()
+	if err != nil {
+		log.Fatal(err)
+	}
+	log.Printf("***************[5]****************** %+v \n", getAllSnapV1Resp)
+
+	getSnapV1Resp, err := powerSnapClient.V1SnapshotsGet(snapshot_id)
+	if err != nil {
+		log.Fatal(err)
+	}
+	log.Printf("***************[6]****************** %+v \n", getSnapV1Resp)
 }

go.mod

@@ -1,6 +1,6 @@
 module github.com/IBM-Cloud/power-go-client
 
-go 1.22
+go 1.22.0
 
 require (
 	github.com/IBM/go-sdk-core/v5 v5.15.3

go.sum

@@ -78,8 +78,8 @@ github.com/oklog/ulid v1.3.1 h1:EGfNDEx6MqHz8B3uNV6QAib1UR2Lm97sHi3ocA6ESJ4=
 github.com/oklog/ulid v1.3.1/go.mod h1:CirwcVhetQ6Lv90oh/F+FBtV6XMibvdAFo93nm5qn4U=
 github.com/onsi/ginkgo v1.16.5 h1:8xi0RTUf59SOSfEtZMvwTvXYMzG4gV23XVHOZiXNtnE=
 github.com/onsi/ginkgo v1.16.5/go.mod h1:+E8gABHa3K6zRBolWtd+ROzc/U5bkGt0FwiG042wbpU=
-github.com/onsi/gomega v1.31.1 h1:KYppCUK+bUgAZwHOu7EXVBKyQA6ILvOESHkn/tgoqvo=
-github.com/onsi/gomega v1.31.1/go.mod h1:y40C95dwAD1Nz36SsEnxvfFe8FFfNxzI5eJ0EYGyAy0=
+github.com/onsi/gomega v1.29.0 h1:KIA/t2t5UBzoirT4H9tsML45GEbo3ouUnBHsCfD2tVg=
+github.com/onsi/gomega v1.29.0/go.mod h1:9sxs+SwGrKI0+PWe4Fxa9tFQQBG5xSsSbMXOI8PPpoQ=
 github.com/opentracing/opentracing-go v1.2.0 h1:uEJPy/1a5RIPAJ0Ov+OIO8OxWu77jEv+1B0VhjKrZUs=
 github.com/opentracing/opentracing-go v1.2.0/go.mod h1:GxEUsuufX4nBwe+T+Wl9TAgYrxe9dPLANfrWvHYVTgc=
 github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=