Fix Public Gateway and Floating IP resource bug

internal/providers/terraform/ibm/ibm.go

@@ -65,7 +65,6 @@ var globalCatalogServiceId = map[string]catalogMetadata{
 	"ibm_pi_volume":                 {"Power Systems Storage Volume", []string{}, nil, "https://cloud.ibm.com/docs/power-iaas?topic=power-iaas-pricing-virtual-server#storage-type"},
 	"ibm_cos_bucket":                {"Object Storage Bucket", []string{}, nil, "https://cloud.ibm.com/objectstorage/create#pricing"},
 	"ibm_is_lb":                     {"is.load-balancer", []string{}, nil, "https://cloud.ibm.com/vpc-ext/provision/loadBalancer"},
-	"ibm_is_public_gateway":         {"is.public-gateway", []string{"ibm_is_floating_ip"}, nil, "https://cloud.ibm.com/vpc-ext/provision/vpc"},
 	"kms":                           {"ee41347f-b18e-4ca6-bf80-b5467c63f9a6", []string{}, nil, "https://cloud.ibm.com/catalog/services/key-protect"},
 	"cloud-object-storage":          {"dff97f5c-bc5e-4455-b470-411c3edbe49c", []string{}, nil, "https://cloud.ibm.com/objectstorage/create#pricing"},
 	"roks":                          {"containers.kubernetes.cluster.roks", []string{}, nil, "https://cloud.ibm.com/kubernetes/catalog/about?platformType=openshift"},

internal/providers/terraform/ibm/registry.go

@@ -17,7 +17,6 @@ var ResourceRegistry []*schema.RegistryItem = []*schema.RegistryItem{
 	getCloudantRegistryItem(),
 	getPiInstanceRegistryItem(),
 	getIsLbRegistryItem(),
-	getIsPublicGatewayRegistryItem(),
 	getIbmPiVolumeRegistryItem(),
 	getDatabaseRegistryItem(),
 	getIsVpnServerRegistryItem(),
@@ -106,6 +105,7 @@ var FreeResources = []string{
 	"ibm_is_network_acl",
 	"ibm_is_network_acl_rule",
 	"ibm_is_placement_group",
+	"ibm_is_public_gateway",
 	"ibm_is_security_group",
 	"ibm_is_security_group_rule",
 	"ibm_is_security_group_target",

internal/providers/terraform/ibm/testdata/is_floating_ip_test/is_floating_ip_test.golden

@@ -1,22 +1,24 @@
 
- Name                                              Monthly Qty  Unit                        Monthly Cost 
-
- ibm_is_floating_ip.testFloatingIp                                                                       
- └─ Floating IP us-south                                     1  Instance                           $1.05 
-
- ibm_is_instance.testInstance                                                                            
- ├─ CPU hours (2 CPUs, us-south-1)         Monthly cost depends on usage: $0.0249876337 per CPU hours    
- └─ Memory hours (8 GB, us-south-1)        Monthly cost depends on usage: $0.00506833 per Memory hours   
-
- ibm_is_vpc.testVpc                                                                                      
- ├─ VPC instance                                             1  Instance                           $0.00 
- ├─ VPC egress free allowance (first 5GB)  Monthly cost depends on usage: $0.00 per GB                   
- └─ VPC egress us-south (first 9995 GB)    Monthly cost depends on usage: $0.090915 per GB               
- └─ VPC egress us-south (next 40000 GB)    Monthly cost depends on usage: $0.086735 per GB               
- └─ VPC egress us-south (next 100000 GB)   Monthly cost depends on usage: $0.07315 per GB                
- └─ VPC egress us-south (over 149995 GB)   Monthly cost depends on usage: $0.05225 per GB                
-
- OVERALL TOTAL                                                                                     $1.05 
+ Name                                                               Monthly Qty  Unit                        Monthly Cost 
+
+ ibm_is_floating_ip.testFloatingIp                                                                                        
+ └─ Floating IP us-south                                                      1  Instance                           $1.05 
+
+ ibm_is_instance.testInstance                                                                                             
+ ├─ CPU hours (2 CPUs, us-south-1) (first 1 CPU hours)      Monthly cost depends on usage: $0.31 per CPU hours            
+ ├─ CPU hours (2 CPUs, us-south-1) (over 0 CPU hours)       Monthly cost depends on usage: $0.0249876337 per CPU hours    
+ └─ Memory hours (8 GB, us-south-1) (first 1 Memory hours)  Monthly cost depends on usage: $0.57 per Memory hours         
+ └─ Memory hours (8 GB, us-south-1) (over 0 Memory hours)   Monthly cost depends on usage: $0.00506833 per Memory hours   
+
+ ibm_is_vpc.testVpc                                                                                                       
+ ├─ VPC instance                                                              1  Instance                           $0.00 
+ ├─ VPC egress free allowance (first 5GB)                   Monthly cost depends on usage: $0.00 per GB                   
+ └─ VPC egress us-south (first 9995 GB)                     Monthly cost depends on usage: $0.090915 per GB               
+ └─ VPC egress us-south (next 40000 GB)                     Monthly cost depends on usage: $0.086735 per GB               
+ └─ VPC egress us-south (next 100000 GB)                    Monthly cost depends on usage: $0.07315 per GB                
+ └─ VPC egress us-south (over 149995 GB)                    Monthly cost depends on usage: $0.05225 per GB                
+
+ OVERALL TOTAL                                                                                                      $1.05 
 ──────────────────────────────────
 6 cloud resources were detected:
 ∙ 3 were estimated, 2 of which include usage-based costs, see https://infracost.io/usage-file