Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CoreOS Satellite attach script: #6

Merged
merged 6 commits into from
Jul 28, 2022
Merged

Support for CoreOS Satellite attach script: #6

merged 6 commits into from
Jul 28, 2022

Conversation

bhpratt
Copy link
Contributor

@bhpratt bhpratt commented Jul 7, 2022

Per requirements here: IBM-Cloud/terraform-provider-ibm#3838

Adding in support for the user to choose RHEL or RHCOS as the operating system for adding hosts to Satellite location

@bhpratt bhpratt marked this pull request as draft July 7, 2022 20:01
@bhpratt bhpratt marked this pull request as ready for review July 8, 2022 19:42
@bhpratt
Copy link
Contributor Author

bhpratt commented Jul 8, 2022

Tested locally. Used these setting

	controller := "<location-id>"
	labelMap := make(map[string]string)
	operatingSystem := "RHEL"
	attachSatHostOptions.Controller = &controller
	attachSatHostOptions.Labels = labelMap
	attachSatHostOptions.OperatingSystem = &operatingSystem

That correctly provided a RHEL script. No operatingSystem provided generated a RHEL attach script. RHCOS generated a CoreOS attach script. Other values for operatingSystem generated an error as expected.

@hkantare hkantare merged commit 60ff775 into IBM-Cloud:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants