Fix compiling in ruby 3.0 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running build should expose the issue seen in #1
|
@petergoldstein if you have a sec to see if this seems right to you I'd appreciate it |
|
@IAPark Do you need to update the README as well? |
|
I'm honestly not sure. Looking at @ankane 's tokenizers-ruby, I'm not sure the switch from |
|
I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1 which highlighted that builds are failing in Ruby 3.0. I think this was because while this project started with rb_sys I'd briefly experimented with the native rust extension support available in Ruby 3.1+. While it worked I did end up switching back, but it looks like I never switched the gemspec file back.