-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excise "exclude" column from meta and add a own attribute #759
Excise "exclude" column from meta and add a own attribute #759
Conversation
Codecov Report
@@ Coverage Diff @@
## main #759 +/- ##
=======================================
- Coverage 94.5% 94.4% -0.1%
=======================================
Files 59 59
Lines 6016 6080 +64
=======================================
+ Hits 5686 5744 +58
- Misses 330 336 +6
|
Responding to this comment by @byersiiasa
You can currently do the following in the new API (in addition to the validation methods): df.exclude = False to change the entire df.exclude[idx] = True where So you could do the following
Is that good enough for your use case? Or are there other uses that you encountered? |
Yes - that sounds good! |
Merging after discussions in the MESSAGE group meeting... |
Please confirm that this PR has done the following:
Name of contributors Added to AUTHORS.rstDescription of PR
This PR excises the "exclude" column from the "meta" attribute to reduce confusion among users why an exclude column is added from a timeseries-only data file. Also, this currently requires some tinkering in the IIASA Scenario Explorer upload workflow.
The PR:
exclude
and refactors all validation methods such that the argumentexclude_on_fail
changes this attributefilter(exclude=<value>)
works as expectedexclude
attribute (with a log message)fyi @gidden @byersiiasa @phackstock
closes #755