Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excise "exclude" column from meta attribute #758

Closed
wants to merge 18 commits into from

Conversation

danielhuppmann
Copy link
Member

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

This PR excises the "exclude" column from the "meta" attribute to reduce confusion among users why an exclude column is added (but then again not imported to the IIASA Scenario Explorer.

The PR:

  • creates a new attribute exclude and refactors all validation methods such that the argument exclude_on_fail changes this attribute
  • extends the filter such that filter(exclude=<value> works as expected
  • adds "exclude" to the list of illegal column names for (timeseries) data and meta
  • when importing an xlsx file created with pyam < 2.0 (which has an "exclude" column in "meta"), that column is moved to the new exclude attribute (with a log message)
  • streamlines a number of tests

fyi @gidden @byersiiasa @phackstock

closes #755

@danielhuppmann danielhuppmann self-assigned this Jul 5, 2023
@danielhuppmann danielhuppmann changed the title Cleanup/meta Excise "exclude" column from meta attribute Jul 5, 2023
@danielhuppmann
Copy link
Member Author

Wrong head branch...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor the "exclude" feature
1 participant