Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement compatibility with pandas 2.0 #739

Merged
merged 12 commits into from
Apr 14, 2023

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Apr 7, 2023

Description of PR

This PR implements changes necessary for tests to pass with pandas v2.0 and nbconvert v7.3.

Note that the pytest-legacy workflow and the py3.7-tests (where pandas 2.0 was not released) ensure that also older versions of pandas continue to work with the changes required for compatibility with pandas 2.0.

Closes #738

@danielhuppmann danielhuppmann self-assigned this Apr 7, 2023
@danielhuppmann danielhuppmann added the dependencies Pull requests that update a dependency file label Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #739 (b525775) into main (a87e64e) will increase coverage by 0.0%.
The diff coverage is 94.2%.

@@          Coverage Diff          @@
##            main    #739   +/-   ##
=====================================
  Coverage   95.1%   95.1%           
=====================================
  Files         59      59           
  Lines       6057    6006   -51     
=====================================
- Hits        5761    5713   -48     
+ Misses       296     293    -3     
Impacted Files Coverage Δ
pyam/figures.py 38.0% <ø> (ø)
tests/test_statistics.py 100.0% <ø> (ø)
tests/test_time.py 100.0% <ø> (ø)
pyam/statistics.py 85.5% <87.5%> (+0.7%) ⬆️
tests/test_tutorials.py 89.4% <92.8%> (-5.2%) ⬇️
pyam/iiasa.py 87.3% <100.0%> (ø)
pyam/utils.py 92.7% <100.0%> (+<0.1%) ⬆️
tests/test_core.py 100.0% <100.0%> (ø)
tests/test_filter.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielhuppmann danielhuppmann marked this pull request as ready for review April 10, 2023 18:08
@danielhuppmann
Copy link
Member Author

fyi @phackstock @gidden @coroa

@danielhuppmann danielhuppmann merged commit 449b77c into IAMconsortium:main Apr 14, 2023
@danielhuppmann danielhuppmann deleted the quickfix/pandas_2.0 branch April 18, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pandas 2.0 breaks some tests
1 participant