Validation for illegal column names in data
#734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coroa
approved these changes
Mar 3, 2023
| @@ -262,12 +262,18 @@ def _intuit_column_groups(df, index, include_index=False): | |||
| existing_cols = existing_cols.union(df.columns) | |||
|
|
|||
| # check that there is no column in the timeseries data with reserved names | |||
| if None in existing_cols: | |||
| raise ValueError("Unnamed column in `data`: None") | |||
There was a problem hiding this comment.
This could also be part of the ILLEGAL_COLS, i guess, but maybe the message is just clearer this way.
There was a problem hiding this comment.
Right, the reason why this is not part ILLEGAL_COLS is that we have an easy solution for string-column-names, which is part of the error message - but this doesn't work (easily) for None.
Codecov Report
@@ Coverage Diff @@
## main #734 +/- ##
=====================================
Coverage 95.0% 95.1%
=====================================
Files 59 59
Lines 6020 6044 +24
=====================================
+ Hits 5725 5748 +23
- Misses 295 296 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Documentation AddedName of contributors Added to AUTHORS.rstDescription of PR
During review of #729, I noticed that there may be issues when initializing an IamDataFrame with an unnamed column (None or empty string) - both could give unexpected behavior. This PR adds these two corner cases to the validation routine.