Ipcc color update #314
Merged
Ipcc color update #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Dec 29, 2019
gidden
force-pushed
the
ipcc-color-update
branch
from
8403cd7
to
7d345d2
Compare
znicholls
approved these changes
Dec 29, 2019
There was a problem hiding this comment.
lgtm, I had this hope that the colours would be made machine readable or put in a package (IPCC-WG1/colormaps#2) but doesn't seem to be the case yet.
|
I considered putting in a pr, but thought that this happens so
infrequently, it may just not be worth it (other than having a single point
of reference)
…On Sun, Dec 29, 2019, 15:13 Zeb Nicholls ***@***.***> wrote:
***@***.**** approved this pull request.
lgtm, I had this hope that the colours would be made machine readable or
put in a package (IPCC-WG1/colormaps#2
<IPCC-WG1/colormaps#2>) but doesn't seem to be
the case yet.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#314?email_source=notifications&email_token=AAKUAEITSPRFJ24ORSAVPNLQ3EHFXA5CNFSM4KBBXNQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQK5MLA#pullrequestreview-336975404>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKUAEOZFCXXNXQGFBJI4J3Q3EHFXANCNFSM4KBBXNQA>
.
|
danielhuppmann
requested changes
Dec 30, 2019
|
should be g2g @danielhuppmann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Description of PR
The IPCC TSU has updated their preferred SSP/RCP color pallete for AR6. It now exists in a public repo here. This PR updates our color mappings to match this and includes new "SSP only" colors as well.
Probably best for at least @znicholls to take a look and confirm one or two of the translations with their own info. @danielhuppmann happy for you to give the a-ok as well if you want =)