-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Region aggregation if region missing #267
Region aggregation if region missing #267
Conversation
@danielhuppmann @gidden thoughts would be great here. The new tests currently fail in a cryptic way. The question is, if you call |
From a quick look, it seems that the command tries to return the object as a pivoted On the question "how do we expect this to behave", I would follow the behaviour in Line 831 in 127680a
|
@danielhuppmann this should be good to go |
a5d0db9
to
cf09266
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @znicholls for improving the user-friendliness of the region.aggregation-checking function!
Please confirm that this PR has done the following:
Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
Description of PR
Updates pyam so behaviour of
check_aggregate_region
is sensible even if the region your checking is missing.