Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deliberately exclude pandas 0.24.0 and update dev environment creation instructions #228

Merged
merged 6 commits into from
May 8, 2019

Conversation

znicholls
Copy link
Collaborator

@znicholls znicholls commented Apr 29, 2019

Please confirm that this PR has done the following:

  • Tests Added (N/A)
  • Documentation Added (N/A)
  • Description in RELEASE_NOTES.md Added

Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)

Please add a single line in the release notes similar to the following:

- (#XX)[http://link-to-pr.com] Added feature which does something

Description of PR

Deliberately excludes Pandas 0.24.0 from compatible versions due to a bug (bug was fixed in 0.24.1)

@znicholls
Copy link
Collaborator Author

quick one just to make dependencies clearer for users

@znicholls znicholls changed the title Deliberately exclude pandas 0.24.0 Deliberately exclude pandas 0.24.0 and update dev environment creation instructions Apr 29, 2019
@gidden
Copy link
Member

gidden commented Apr 29, 2019

should we also add here geopandas<0.5.0 for the moment?

@coveralls
Copy link

coveralls commented Apr 29, 2019

Coverage Status

Coverage remained the same at 91.918% when pulling f9f0c6c on znicholls-patch-1 into 4077929 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.918% when pulling 7715200 on znicholls-patch-1 into 4077929 on master.

setup.py Outdated Show resolved Hide resolved
@gidden
Copy link
Member

gidden commented May 7, 2019

Hey @znicholls, is this good to go for inclusion in 0.2.0?

@znicholls
Copy link
Collaborator Author

It is now :)

@gidden
Copy link
Member

gidden commented May 8, 2019

looks great, thanks @znicholls !

@gidden gidden merged commit 205001a into master May 8, 2019
@gidden gidden deleted the znicholls-patch-1 branch May 8, 2019 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants