Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function to normalize #197

Merged
merged 6 commits into from
Feb 26, 2019
Merged

Conversation

gidden
Copy link
Member

@gidden gidden commented Feb 18, 2019

starting to add a function to normalize all data to a specific time value

@coveralls
Copy link

coveralls commented Feb 18, 2019

Coverage Status

Coverage increased (+0.1%) to 84.604% when pulling d8b74b5 on gidden:normalize into fcb81fe on IAMconsortium:master.

@gidden
Copy link
Member Author

gidden commented Feb 18, 2019

we can probably rework this to normalize to any specific subset of data, just works for time at the moment

@gidden gidden changed the title [WIP] add function to normalize add function to normalize Feb 21, 2019
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but a few minor changes, please.

And just for kicks: why not (also) have an API like df.normalize(year=2005, inplace=True)? Instead of cols, which might be difficult if you want to support normalizing on multiple columns.

pyam/core.py Outdated Show resolved Hide resolved
pyam/core.py Outdated Show resolved Hide resolved
pyam/core.py Outdated Show resolved Hide resolved
@gidden
Copy link
Member Author

gidden commented Feb 26, 2019

Ok @danielhuppmann all suggested changes made!

@danielhuppmann
Copy link
Member

thanks @gidden, looks great! do you want to add it to the release notes for completeness?

@gidden
Copy link
Member Author

gidden commented Feb 26, 2019

done!

@danielhuppmann danielhuppmann merged commit bc5fcbc into IAMconsortium:master Feb 26, 2019
@gidden gidden deleted the normalize branch June 15, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants