Refactor to allow subclasses to set their own time format #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Jan 24, 2019
znicholls
force-pushed
the
allow-custom-time-formatting
branch
from
348cdbb
to
26f19e3
Compare
stickler-ci
reviewed
Jan 25, 2019
Merged
|
Hey Zeb, looks like a good effort here. I made a PR into your branch with some of the nontrivial things I was thinking of (plus a little cleanup of surrounding code you didn't touch). Let me know if you have any questions there. More comments coming inline. |
gidden
reviewed
Jan 25, 2019
|
Agreed on your points!
…On Fri, Jan 25, 2019, 2:18 PM Daniel Huppmann ***@***.*** wrote:
***@***.**** commented on this pull request.
------------------------------
In pyam/core.py
<#177 (comment)>:
> @@ -83,6 +86,19 @@ def __init__(self, data, **kwargs):
if 'exec' in run_control():
self._execute_run_control()
+ def _format_data_time_col(self):
I think that a substantial part of our users and use cases will still
revolve around yearly data, so I'd very much like to retain the option to
do df.filter(year=2020). Plus we should cater to the use case of having
categorical sub-annual specifications like ['summer-day', 'winter-night'].
If this can be maintained while removing year on the backend, fine by me.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#177 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABVAEWrY7pXrS2KlaG5j5GoJHsXiuhQGks5vGwRAgaJpZM4aR5ny>
.
|
A few touch ups and cleaner logic for column discovery
stickler-ci
reviewed
Jan 25, 2019
|
looks great! Thanks @znicholls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please confirm that this PR has done the following:
Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
Description of PR
This PR moves the formatting of the time column from
pyam/utils.pyinto a method ofIamDataFrame. This allows subclasses to avoid converting to pandas datetime if their timespan is greater than the pandas maximum of 584 years (see https://stackoverflow.com/questions/32888124/pandas-out-of-bounds-nanosecond-timestamp-after-offset-rollforward-plus-adding-a).