Replace tags in attribute lists and dicts #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also corrected the test from the previous commits. The `components` attribute is a list of one-element dictionaries in the yaml file, but is apparently flattened during parsing and becomes a simple dict instead.
There was a problem hiding this comment.
Thanks @korsbakken, very nice - just a few suggestions for consistency...
Co-authored-by: Daniel Huppmann <[email protected]>
Thanks @danielhuppmann, those suggestions make good sense, I have added and committed them to the PR now. |
|
The suggested changes appear to cause tests to fail, not clear why. It introduces an unintentional blank line in the middle of a definition, and an inconsistency in the CO2 and CH4 unit definitions, but new less obvious failures appear after fixing that. |
The last commit contained an unintentional blank line in test_codelist.py, and inconsistent indentation in data/tagged_codelis/tag_species.yaml that was causing an error when creating the CodeList.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (hopefully) solves issue #342 . It modifies
Code.replace_tagto descend into attribute lists and dicts, replaing each string in list elements of dict values that contain a tag. Adds a test and test data that contains a code with tags in thecomponentsattribute.