Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin versions of common and legacy definitions for test #349

Merged
merged 1 commit into from
May 28, 2024
Merged

Pin versions of common and legacy definitions for test #349

merged 1 commit into from
May 28, 2024

Conversation

phackstock
Copy link
Contributor

Closes #348.

@phackstock phackstock added the bug Something isn't working label May 28, 2024
@phackstock phackstock self-assigned this May 28, 2024
@danielhuppmann
Copy link
Member

Is there already a test for the hash feature? If yes, I‘d prefer to change the variable that is being tested. Otherwise ok.

@phackstock
Copy link
Contributor Author

Just checked, there actually isn't a test for the hash feature.

danielhuppmann
danielhuppmann approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phackstock phackstock merged commit 3f981c7 into IAMconsortium:main May 28, 2024
11 checks passed
@phackstock phackstock deleted the fix/failing-legacy-definitions-test branch May 28, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhuppmann danielhuppmann danielhuppmann approved these changes

Assignees

@phackstock phackstock

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nightly tests failing because of legacy definitions update
2 participants
@phackstock @danielhuppmann