Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MetaValidator tests to not use exclude indicator #272

Conversation

danielhuppmann
Copy link
Member

This PR implements the change that the pyam-meta-attribute does not (any more) have an indicator exclude.

This PR is not compatible with the latest release-version of pyam, but I think that this is not a concern because:

  • the pypi-release-versions are compatible
  • the latest versions on GitHub are compatible
  • we add a dependency on pyam>2.0 in nomenclature after the next release

@danielhuppmann
Copy link
Member Author

danielhuppmann commented Aug 7, 2023

Also, the nightly tests will not be run on Sunday so as to not spoil my weekend...

Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @danielhuppmann.
Good to merge from my side.

@danielhuppmann danielhuppmann merged commit eaf2fae into IAMconsortium:main Aug 7, 2023
11 checks passed
@danielhuppmann danielhuppmann deleted the quickfix/pyam-exclude-attribute branch August 7, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants