Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct test pypi installation test #202

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

phackstock
Copy link
Contributor

This is a tiny correction to DEVELOPING.rst. As the tests are not bundled with the package you cannot check that the tests are working.

Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Maybe create an issue so that this can be tackled at some point?

@phackstock
Copy link
Contributor Author

Maybe create an issue so that this can be tackled at some point?

Do you mean we should bundle the tests with the package? I was under the impression that that's not standard practice.

@danielhuppmann
Copy link
Member

Ok, then let's not do this...

@phackstock
Copy link
Contributor Author

Alright, sounds good. I just double checked and it does not seem like pyam includes the tests either.

@phackstock phackstock merged commit 57b08f7 into IAMconsortium:main Nov 23, 2022
@phackstock phackstock deleted the fix/developing branch January 16, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants