Fix/stray tags

nomenclature/codelist.py

@@ -134,6 +134,14 @@ def cast_variable_components_args(cls, v, values):
 
         return v
 
+    @validator("mapping")
+    def check_stray_tag(cls, v, values):
+        """Check that no '{' are left in codes after tag replacement"""
+        for code in v:
+            if "{" in code:
+                raise ValueError(f"Unexpected {{}} in codelist : {code}")
+        return v
+
     def __setitem__(self, key, value):
         if key in self.mapping:
             raise DuplicateCodeError(name=self.name, code=key)

tests/data/stray_tag/definitions/variable/tag_fuel.yaml

@@ -0,0 +1,3 @@
+- Fuel:
+  - Coal:
+      definition: coal

tests/data/stray_tag/definitions/variable/variables.yaml

@@ -0,0 +1,9 @@
+- Primary Energy:
+    definition: Total primary energy consumption
+    unit: EJ/yr
+- Primary Energy|{Feul}:
+    definition: Primary energy consumption of {Fuel}
+    unit: EJ/yr
+- Share|{Fuel}:
+    definition: Share of {Fuel} in the total primary energy mix
+    unit:

tests/test_testing.py

@@ -4,6 +4,7 @@
 
 from nomenclature.testing import assert_valid_yaml
 from conftest import TEST_DATA_DIR
+from nomenclature.codelist import CodeList
 
 
 def test_assert_yaml():
@@ -26,3 +27,13 @@ def test_assert_yaml_fails(caplog):
     obs = log[2].replace("\n", "")  # strip newlines from observed log message
     exp = r"Error parsing file while scanning a simple key.*, line 4, column 1"
     assert re.match(exp, obs)
+
+
+def test_stray_tag_fails():
+    """Check that typos in a tag raises expected error"""
+
+    match = "Unexpected {} in codelist : Primary Energy|{Feul}"
+    with pytest.raises(ValueError, match=match):
+        CodeList.from_directory(
+            "variable", TEST_DATA_DIR / "stray_tag" / "definitions" / "variable"
+        )