-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check that weight variables exist #133
Merged
phackstock
merged 12 commits into
IAMconsortium:main
from
phackstock:feature/variable-weight-check
Jul 8, 2022
Merged
Check that weight variables exist #133
phackstock
merged 12 commits into
IAMconsortium:main
from
phackstock:feature/variable-weight-check
Jul 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhuppmann
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice improvement, thanks! Just a few suggestions for shorter, more readable documentation and error messages.
Co-authored-by: Daniel Huppmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #132.
Features added
The validation of the variable code list now includes a check that all variables mentioned as a
weight
also have their own entry in the list. I've written the validator so that it collects all missing weight variables and does not throw an error for the first one. This way multiple errors can be fixed in one go.I added a point in the documentation to highlight that the weight is required.
I also took the liberty to slightly refactor the codelist validators. The main change there is the switch from using
root_validator()
tovalidator("mapping")
.The reason for this change is that in the validators only modify and validate the
mapping
attribute. Thename
attribute is mainly used for better error reporting in this case. The way how to access multiple attributes in a non-root validator is addingv
andvalues
to the list of input variables (details can be found under the code example of "Validators" https://pydantic-docs.helpmanual.io/usage/validators/). As an example:If you don't like the switch from the
root_validator
though I can also revert it.Looking forward to your comments.