Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify illegal character(s) found and respective attribute(s) #456

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dc-almeida
Copy link
Collaborator

Closes #451

@dc-almeida dc-almeida requested a review from phackstock January 14, 2025 09:36
@dc-almeida dc-almeida added the enhancement New feature or request label Jan 14, 2025
@dc-almeida dc-almeida self-assigned this Jan 14, 2025
@dc-almeida dc-almeida marked this pull request as ready for review January 14, 2025 09:45
Copy link
Contributor

@phackstock phackstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions, then good to merge.

nomenclature/codelist.py Outdated Show resolved Hide resolved
nomenclature/codelist.py Show resolved Hide resolved
dc-almeida and others added 2 commits January 15, 2025 12:43
Copy link
Member

@danielhuppmann danielhuppmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, good to be merged either way...

nomenclature/codelist.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include which illegal character was found in a faulty variable and in which attribute
3 participants