Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename repository attribute in Code for readability #458

Open
dc-almeida opened this issue Jan 15, 2025 · 0 comments · May be fixed by #459
Open

Rename repository attribute in Code for readability #458

dc-almeida opened this issue Jan 15, 2025 · 0 comments · May be fixed by #459
Assignees
@dc-almeida

Comments

@dc-almeida
Copy link
Collaborator

dc-almeida commented Jan 15, 2025 •
edited
Loading

Not part of this PR, but I'd suggest renaming this attribute to from_external_repository. This would make the code easier to read.

Originally posted by @phackstock in #456 (comment)
@dc-almeida dc-almeida linked a pull request Jan 15, 2025 that will close this issue
Open
@dc-almeida dc-almeida self-assigned this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dc-almeida dc-almeida

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add from_external_repository attribute to Code dc-almeida/nomenclature
1 participant
@dc-almeida