Final Refactoring - Syw UID2-4158 token gen code refactoring user identity #1123

sunnywu · 2024-10-28T07:06:30Z

Read https://thetradedesk.atlassian.net/browse/UID2-4159
Refactor EncryptedTokenEncoder#encodeIntoIdentityResponse
Moved toJson methods into IdentityResponse from UIDOperatorVerticle class
Use EncryptedTokenEncoder directly inside UIDOperatorService class instead of ITokenEncoder interfact so it's easier to jump to references and we haven't really created any other ITokenEncoder varantsi
Removed the UserIdentity's refreshedAt field as that's redundant and currently set to the same value as the AdvertisingTokenInput/RefreshTokenInput#createdAt timestamp.
Renamed some token variable names to adTokenInput and refreshTokenInput to make it clearer
Removed privacyBits and establishedAt from UserIdentity/HashedDiidentity/RawUidIdentity. EstbalishedAt is kept inside FirstLevelHashIdentity as the time the first level hash was created..
Also, privacyBits and establishedAt are generated from either a. in a brand new token generation call (by default should be 1 and the timestamp at the time of the call) b. or, during token refresh logic, these fields will be inherited from previous refresh token.
RefreshTokenRequest, AdvertisingTokenRequest and IdentityRequest will now require to store privacyBits and establishedAt itself as a compromise.
generateIdentity will now take in a privacyBits param.
Created verifyFirstLevelHashIdentityAndEstablishedAt method for verifying FirstLevelHashIdentity and added more checks for FirstLevelHash and check the correctness of raw Uid/First level hash in various unit tests
Added PrivacyBitsTest/IdentityResponseTest/RawUidResponseTest classes and added some extra check for firstLevelHash in existing tests
Replace int privacy bits type use to proper PrivacyBits class instance
Refactored UIDOperatorVerticleTest unit tests to standardise the advertisingTokenRequest/refreshTokenRequest verification(2edcb05)

Changes from 2024-12-01
14. Renamed TokenUtils.java's functions to be blatently clear on the input value type
15. Fixed the old testIdentityMapForOptOutUser test that was using raw DII as a hash
16. Renamed all uses of IdentityString/IdentityHash variables to rawDii and hashedDii
17. Renamed IdentityType to DiiType
18. In InputUtil, renamed Identity* member variable/methods to Dii* to indicate it's Dii
19. Change TokenUtils class getIdentityHash to getDiiHash and same for getDiiHashString
20. Renamed FirstLevelHashIdentity/HashedDiiIdentity/RawUidIdentity to FirstLevelHash/HashedDii/RawUid
21. Renamed RawUidResponse to IdentityMapResponseItem, MapRequest to IdentityMapRequestItem
22. Renamed IUIDOperatorService.mapHashedDiiIdentity to mapHashedDii
23. Renamed IdentityRequest/IdentityResponse to TokenGenerateRequest/Response
24. Renamed RefreshTokenRequest/RefreshResponse to TokenRefreshRequest/TokenRefreshResponse
25. Renamed AdvertisingTOkenInput/RefreshTokenInput to AdvertisingTokenRequest/RefreshTOkenRequest

…f variables which don't just include tokens

…ts for clarity

…LevelHashIdentity and RawUidIdentity as UserIdentity is a very vague term and one needs to read function calls to really understand whether the UserIdentity class has hashed DII, first level hash or raw Uid.

2. Rename RefreshToken class to RefreshTokenInput 3. Rename createAdvertisingToken/createRefreshToken methods to createAdvertisingTokenInput/createRefreshTokenInput

…ii/FirstLevelHash/RawUidIdentity sub-classes

…ponse

2. Moved toJson methods into IdentityResponse from UIDOperatorVerticle class

…stead of ITokenEncoder interfact so it's easier to jump to references and we haven't really created any other ITokenEncoder variants

…ertisingId to generateRawUid

2. Renamed AdvertisingId to RawUid in most operator codes (except optout store related)

…59-token-gen-code-refactoring

…onse

…59-token-gen-code-refactoring

2. Renamed RawUidResult to RawUidResponse 3. rename some id variable to rawUid to make it clearer 4. more comments

…xed the UserIdentity/FirstLevelHashIdentity class uses to HashedDiiIdentity instead in IdentityMapBenchmark and TokenEndecBenchmark

2. Renamed RawUidResult to RawUidResponse 3. rename some id variable to rawUid to make it clearer 4. more comments

sunnywu · 2024-10-30T05:24:17Z

src/main/java/com/uid2/operator/vertx/UIDOperatorVerticle.java

                        new IdentityRequest(
-                                new PublisherIdentity(siteId, 0, 0),
-                                input.toUserIdentity(this.identityScope, 1, Instant.now()),


1, Instant.now() became the default param for IdentityRequest constructor now

sunnywu · 2024-10-30T05:24:39Z

src/main/java/com/uid2/operator/vertx/UIDOperatorVerticle.java

                        new IdentityRequest(
-                                new PublisherIdentity(siteId, 0, 0),
-                                input.toUserIdentity(this.identityScope, 1, Instant.now()),


1, Instant.now() became the default param for IdentityRequest constructor now

… instead of oken

sunnywu · 2024-10-30T05:30:30Z

src/main/java/com/uid2/operator/vertx/UIDOperatorVerticle.java

@@ -1235,11 +1237,11 @@ private void handleIdentityMapV1(RoutingContext rc) {
        }
        try {
            final Instant now = Instant.now();
-            final MappedIdentity mappedIdentity = this.idService.map(input.toUserIdentity(this.identityScope, 0, now), now);


identity/map call doesn't use the 0 privacy bits and established at timestamp

sunnywu · 2024-10-30T05:48:53Z

src/test/java/com/uid2/operator/UIDOperatorServiceTest.java

@@ -48,13 +55,13 @@ public class UIDOperatorServiceTest {
    ExtendedUIDOperatorService uid2Service;
    ExtendedUIDOperatorService euidService;
    Instant now;
-
+    RotatingSaltProvider saltProvider;


moved here so we could use it to verify generated first level hash/uid result

… & refreshTokenInput's

…efreshTokenInput verification

asloobq

This really makes it easy to understand the core raw UID and token generation. Thanks for doing this.

asloobq · 2024-11-01T17:16:14Z

src/main/java/com/uid2/operator/model/MapRequest.java

            OptoutCheckPolicy optoutCheckPolicy,
            Instant asOf)
    {
-        this.userIdentity = userIdentity;


there is an existing styling issue here - { should be on previous line. Just a minor suggestion

asloobq · 2024-11-01T17:21:48Z

src/main/java/com/uid2/operator/service/IUIDOperatorService.java


-    MappedIdentity mapIdentity(MapRequest request);
+    RawUidResponse mapIdentity(MapRequest request);


we can rename this method to mapHashedDii to make it more obvious that it accepts Hashed DII

changed to mapHashedDiiIdentity to stay consistent with generateIdentity/refreshIdentity

asloobq · 2024-11-01T17:23:05Z

src/main/java/com/uid2/operator/model/userIdentity/UserIdentity.java

+
+import java.time.Instant;
+
+//base class for all other HshedDii/FirstLevelHash/RawUIDIdentity class and define the basic common fields


nitpick: Typo in HshedDii

asloobq · 2024-11-01T17:23:24Z

src/main/java/com/uid2/operator/model/userIdentity/UserIdentity.java

+import com.uid2.operator.model.IdentityScope;
+import com.uid2.operator.model.IdentityType;
+
+import java.time.Instant;


unused import

asloobq · 2024-11-01T17:29:18Z

src/main/java/com/uid2/operator/service/UIDOperatorService.java

    }

-    private UserIdentity getFirstLevelHashIdentity(IdentityScope identityScope, IdentityType identityType, byte[] identityHash, Instant asOf) {
+    private FirstLevelHashIdentity getFirstLevelHashIdentity(IdentityScope identityScope, IdentityType identityType, byte[] identityHash, Instant asOf) {


why not continue calling it hashedDii instead of byte[] identityHash ?

a common functions used by opt out identity creation like UIDOperatorService#testOptOutIdentityForEmail

uid2-operator/src/main/java/com/uid2/operator/service/UIDOperatorService.java

Line 70 in c6586a5

this.testOptOutIdentityForEmail = getFirstLevelHashIdentity(identityScope, IdentityType.Email,

asloobq · 2024-11-01T22:38:28Z

src/main/java/com/uid2/operator/model/SourcePublisher.java

@@ -1,11 +1,12 @@
 package com.uid2.operator.model;

-public class PublisherIdentity {
+// The original publisher that requests to generate a UID token
+public class SourcePublisher {


I am wondering why some file renames don't show up as such in the changes ? such as RefreshToken to RefreshTokenInput.

asloobq · 2024-11-01T22:56:13Z

src/main/java/com/uid2/operator/vertx/UIDOperatorVerticle.java

@@ -989,13 +991,13 @@ private void handleTokenGenerateV2(RoutingContext rc) {
                    return;
                }

-                final IdentityTokens t = this.idService.generateIdentity(
+                final IdentityResponse t = this.idService.generateIdentity(


can you please rename the variable from t to identityResponse or just response

asloobq · 2024-11-01T22:57:32Z

src/main/java/com/uid2/operator/model/SourcePublisher.java

    public final int siteId;
    public final int clientKeyId;
    public final long publisherId;

-    public PublisherIdentity(int siteId, int clientKeyId, long publisherId) {
+    public SourcePublisher(int siteId, int clientKeyId, long publisherId) {


is always constructed as SourcePublisher(siteId, 0, 0) perhaps make another constructor with default arguments ?

great suggestion - done

That's because it is a half- (well, 5%) baked feature. There is nothing special about values 0. Maybe worth putting some comment about this.

i have added this comment in the class:

// these 2 values are added into adverting/UID token and refresh token payload but // are not really used for any real purposes currently so sometimes are set to 0 // see the constructor below

asloobq · 2024-11-01T22:58:24Z

src/main/java/com/uid2/operator/vertx/UIDOperatorVerticle.java

@@ -1045,14 +1047,14 @@ else if (!input.isValid()) {

        try {
            siteId = AuthMiddleware.getAuthClient(rc).getSiteId();
-            final IdentityTokens t = this.idService.generateIdentity(
+            final IdentityResponse t = this.idService.generateIdentity(


please rename variable t

renamed to response

asloobq · 2024-11-01T23:05:45Z

src/main/java/com/uid2/operator/service/EncryptedTokenEncoder.java

-                new PublisherIdentity(siteId, 0, 0),
-                new UserIdentity(IdentityScope.UID2, IdentityType.Email, identity, privacyBits, Instant.ofEpochMilli(establishedMillis), null));
+                new SourcePublisher(siteId, 0, 0),
+                new FirstLevelHashIdentity(IdentityScope.UID2, IdentityType.Email, identity,


why do we assume that the scope is UID2 and not EUID ?

legacy - this method is for refresh token v2 decoding but we only use v3 refresh token now see

uid2-operator/src/main/java/com/uid2/operator/service/UIDOperatorService.java

Line 103 in a908e1f

this.refreshTokenVersion = TokenVersion.V3;

got it. We can clean up the old code in the near future.

gmsdelmundo · 2024-11-04T02:37:18Z

src/main/java/com/uid2/operator/model/RefreshResponse.java

-    public static RefreshResponse Expired = new RefreshResponse(Status.Expired, IdentityTokens.LogoutToken);
-    public static RefreshResponse Deprecated = new RefreshResponse(Status.Deprecated, IdentityTokens.LogoutToken);
-    public static RefreshResponse NoActiveKey = new RefreshResponse(Status.NoActiveKey, IdentityTokens.LogoutToken);
+    public static RefreshResponse Invalid = new RefreshResponse(Status.Invalid, IdentityResponse.OptOutIdentityResponse);


I don't think these ever get mutated right? I think we can set these to public static final

gmsdelmundo · 2024-11-04T02:39:21Z

src/main/java/com/uid2/operator/store/CloudSyncOptOutStore.java

        if (remoteApiHost == null) {
            handler.handle(Future.failedFuture("remote api not set"));
            return;
        }

        this.webClient.get(remoteApiPort, remoteApiHost, remoteApiPath).
-            addQueryParam("identity_hash", EncodingUtils.toBase64String(firstLevelHashIdentity.id))
-            .addQueryParam("advertising_id", EncodingUtils.toBase64String(advertisingId))
+            addQueryParam("identity_hash", EncodingUtils.toBase64String(firstLevelHashIdentity.firstLevelHash))


Minor point - can we move the . from the previous line to this one, i.e. .addQueryParam instead of just addQueryParam

…put to AdvertisingTokenRequest/RefreshTOkenRequest

asloobq

LGTM.

asloobq · 2024-11-04T17:31:15Z

src/main/java/com/uid2/operator/service/EncryptedTokenEncoder.java

-                new PublisherIdentity(siteId, 0, 0),
-                new UserIdentity(IdentityScope.UID2, IdentityType.Email, identity, privacyBits, Instant.ofEpochMilli(establishedMillis), null));
+                new SourcePublisher(siteId, 0, 0),
+                new FirstLevelHashIdentity(IdentityScope.UID2, IdentityType.Email, identity,


got it. We can clean up the old code in the near future.

atarassov-ttd · 2024-12-01T21:17:24Z

src/main/java/com/uid2/operator/IdentityConst.java

    public static final String ValidateIdentityForEmail = "[email protected]";
    public static final String ValidateIdentityForPhone = "+12345678901";
    public static final byte[] ValidateIdentityForEmailHash = EncodingUtils.getSha256Bytes(IdentityConst.ValidateIdentityForEmail);
    public static final byte[] ValidateIdentityForPhoneHash = EncodingUtils.getSha256Bytes(IdentityConst.ValidateIdentityForPhone);
+
+    // DIIs to use when you want to generate a optout response in token generation or identity map


typo: should be an optout

atarassov-ttd · 2024-12-01T21:19:24Z

src/main/java/com/uid2/operator/model/AdvertisingTokenRequest.java

+import com.uid2.operator.util.PrivacyBits;
+import com.uid2.shared.model.TokenVersion;
+
+// class containing enough data to create a new uid or advertising token


Does it mean "new uid token" and "new advertising token"? If so, what is the difference between the two?

Or does it mean "new uid" and "new advertising token"? If so, why is the advertising token request used to create a new uid? What is a uid in this case anyway?

I should re-phrase better to
class containing enough information to create a new uid token (aka advertising token)

I use the term uid because this is about UID2/EUID. I think we have an understanding previously that from now on we should try to call things UID if it's used for both UID2 & EUID.

atarassov-ttd · 2024-12-01T21:21:05Z

src/main/java/com/uid2/operator/model/AdvertisingTokenRequest.java

+import com.uid2.shared.model.TokenVersion;
+
+// class containing enough data to create a new uid or advertising token
+public class AdvertisingTokenRequest extends VersionedToken {


Why does this class inherit from VersionedToken? Should the base classed be renamed to something like VersionedTokenRequest for consistency?

VersionedToken is a generic store for both AdvertisingTokenRequest and RefreshTokenRequest. So yeh i can rename to VersionedTokenRequest to be consistent.

Fixed

atarassov-ttd · 2024-12-01T21:25:44Z

src/main/java/com/uid2/operator/model/userIdentity/FirstLevelHashIdentity.java

@@ -0,0 +1,30 @@
+package com.uid2.operator.model.userIdentity;


According to this, package names are meant to be all-lowercase. To avoid the two-word, you could try naming the package like com.uid2.operator.model.user or com.uid2.operator.model.identity.

And some more questions/suggestions:

Should other identity related types be moved into this package structure?

Should IdentityType be renamed to DiiType and moved under same package?

i have renamed the package to com.uid2.operator.model.identity.
Renamed IdentityType/IdentityInputType to renamed to DiiType/DiiInputType and added some comments to explain DII and refer to the DII definition on unifiedid.com glossary page

atarassov-ttd · 2024-12-01T21:37:50Z

src/main/java/com/uid2/operator/model/IdentityResponse.java

+
+// this defines all the fields for the response of the /token/generate and /client/generate endpoints before they are
+// jsonified
+public class IdentityResponse {


Given this is used for token generation / refresh responses and that we have identity map API, it can be confusing what this refers to. Should this be something like TokenGenerateResponse instead?

atarassov-ttd · 2024-12-02T00:51:08Z

src/main/java/com/uid2/operator/model/userIdentity/UserIdentity.java

+import com.uid2.operator.model.IdentityType;
+
+//base class for all other HashedDii/FirstLevelHash/RawUIDIdentity class and define the basic common fields
+public abstract class UserIdentity {


Does this abstraction add value?

atarassov-ttd · 2024-12-02T00:52:28Z

src/main/java/com/uid2/operator/model/userIdentity/HashedDiiIdentity.java

+
+// Contains a hash DII,
+// This hash can either be computed from a raw email/phone number DII input or provided by the UID Participant directly
+public class HashedDiiIdentity extends UserIdentity {


Why not call this just HashedDii?

I tend to keep the subclass name consistent so i prefer to add the term Identity here. But having a second thought - 1 problem i had previously with this code base is too many things are called Identity so ok i'll rename and just call it HashedDii

atarassov-ttd · 2024-12-02T00:54:59Z

src/main/java/com/uid2/operator/model/userIdentity/RawUidIdentity.java

+import java.util.Arrays;
+
+// A raw UID is stored inside
+public class RawUidIdentity extends UserIdentity {


Would just RawUid make this easier to grasp? It could have a toString() override which would produce an encoded string.

atarassov-ttd · 2024-12-02T00:56:00Z

src/main/java/com/uid2/operator/model/userIdentity/FirstLevelHashIdentity.java

+import java.util.Arrays;
+
+// Contains a first level salted hash computed from Hashed DII (email/phone number)
+public class FirstLevelHashIdentity extends UserIdentity {


How about just FirstLevelHash?

ok. I still have HashedDiiIdentity and RawUidIdentity but will keep them as is for now

atarassov-ttd · 2024-12-02T00:57:09Z

src/main/java/com/uid2/operator/model/userIdentity/FirstLevelHashIdentity.java

+    }
+
+    // explicitly not checking establishedAt - this is only for making sure the first level hash matches a new input
+    public boolean matches(FirstLevelHashIdentity that) {


Should this be an override of the equals() method?

no, i tend to think creating a equals override means we are making sure all the fields in a class is equal.
But the use case of this method in getGlobalOptOutResult explicitly do not check all fields, i.e. skip establishedAt.

Mainly renaming RefreshTokenRequest/RefreshResponse to TokenRefreshRequest/TokenRefreshResponse

…onse

…entityMapRequestItem - Renamed IUIDOperatorService.mapHashedDiiIdentity to mapHashedDii

… FirstLevelHash/HashedDii/RawUid 2. Removed the abstract class UserIdentity 3. fixed a unit test as removing UserIdentity broke it

2. In InputUtil, renamed Identity* member variable/methods to Dii* to indicate it's Dii 3. Change TokenUtils class getIdentityHash to getDiiHash and same for getDiiHashString

…en-code-refactoring-UserIdentity

sunnywu added 30 commits October 10, 2024 17:08

Renamed IdentityToken class and variables to Identity as it's a set o…

1693ea8

…f variables which don't just include tokens

Renamed Identity.LogoutToken to InvalidIdentity and added some commen…

14fd733

…ts for clarity

Renamed Identity.LogoutToken to InvalidIdentity and added some commen…

7dd3a69

…ts for clarity

renamed getAdvertisingId to MappedIdentity

f2e7a87

Split UserIdentity into 3 distinct classes - HashedDiiIdentity, First…

c0cb6df

…LevelHashIdentity and RawUidIdentity as UserIdentity is a very vague term and one needs to read function calls to really understand whether the UserIdentity class has hashed DII, first level hash or raw Uid.

Added brief comment to Identity/MappedIdentity

0fccf8c

Renamed MappedIdentity to MappedIdentityResult

113e8ca

1. Rename AdvertisingToken class to AdvertisingTokenInput

ae03ff5

2. Rename RefreshToken class to RefreshTokenInput 3. Rename createAdvertisingToken/createRefreshToken methods to createAdvertisingTokenInput/createRefreshTokenInput

Renamed ITokenEncoder.encode to ITokenEncoder.encodeIntoIdentityResponse

5595a15

Renamed Identity.isEmptyToken method to Identity.isNotValid

c6bc08f

Renamed PublisherIdentity to SourcePublisher

639b799

Refactored UserIdentity as a base class which is inherited by HashedD…

d9c730e

…ii/FirstLevelHash/RawUidIdentity sub-classes

Renamed Identity to IdentityResponse

42c5890

Fixed using raw identity in testGenerateTokenForOptOutUser

b62aa54

Renamed RefreshResponse#getIdentity to RefreshResponse#getIdentityRes…

b272d40

…ponse

1. Refactor EncryptedTokenEncoder#encodeIntoIdentityResponse

7e5ad5d

2. Moved toJson methods into IdentityResponse from UIDOperatorVerticle class

Use EncryptedTokenEncoder directly inside UIDOperatorService class in…

131d203

…stead of ITokenEncoder interfact so it's easier to jump to references and we haven't really created any other ITokenEncoder variants

Renamed MappedIdentity to RawUid2Result and UIDOperatorService.getAdv…

8dc0a41

…ertisingId to generateRawUid

1. Fixed RawUid2Result to RawUidResult

91ffa12

2. Renamed AdvertisingId to RawUid in most operator codes (except optout store related)

Merge branch 'syw-UID2-4159-token-gen-code-renaming' into syw-UID2-41…

d9845b7

…59-token-gen-code-refactoring

Renamed IdentityResponse.optOutIdentityResponse to OptOutIdentityResp…

4bb4ccb

…onse

Renamed IdentityResponse.optoutIdentityResponse to OptOutIdentityResp…

8ae5e08

…onse

Merge branch 'syw-UID2-4159-token-gen-code-renaming' into syw-UID2-41…

5a0bb89

…59-token-gen-code-refactoring

Fixed UserIdentity member variables as final and added constructor

b507d8e

1. Addressed code review feedbacks

f5877b7

2. Renamed RawUidResult to RawUidResponse 3. rename some id variable to rawUid to make it clearer 4. more comments

Made UserIdentity abstract first

ccc639f

Fixed a few id variable to rawUid/firstLevelHash to make it clear. Fi…

dabff48

…xed the UserIdentity/FirstLevelHashIdentity class uses to HashedDiiIdentity instead in IdentityMapBenchmark and TokenEndecBenchmark

Fixed UserIdentity member variables as final and added constructor

d8eda03

1. Addressed code review feedbacks

e74e8da

2. Renamed RawUidResult to RawUidResponse 3. rename some id variable to rawUid to make it clearer 4. more comments

Made UserIdentity abstract first

7f4ebf5

sunnywu commented Oct 30, 2024

View reviewed changes

added some comments and renamed refreshIdentity method param to input…

a908e1f

… instead of oken

sunnywu commented Oct 30, 2024

View reviewed changes

sunnywu added 3 commits October 30, 2024 17:30

fixed unit tests checking establishedAt between advertisingTokenInput…

04dfc14

… & refreshTokenInput's

Refactored unit test codes to standardise the advertisingTokenInput/r…

2edcb05

…efreshTokenInput verification

Refactored unit test codes to standardise the advertisingTokenInput/r…

ca44945

…efreshTokenInput verification

sunnywu requested review from asloobq, gmsdelmundo and mcollins-ttd October 30, 2024 07:32

sunnywu marked this pull request as ready for review October 30, 2024 07:32

asloobq reviewed Nov 1, 2024

View reviewed changes

sunnywu added 3 commits November 4, 2024 12:42

Code review feedback

da549b0

renamed IUIDOperatorService#mapIdentity to mapHashedDiiIdentity

c6586a5

renamed to

d76bceb

gmsdelmundo reviewed Nov 4, 2024

View reviewed changes

Code review feedback and renamed AdvertisingTOkenInput/RefreshTokenIn…

23a6f50

…put to AdvertisingTokenRequest/RefreshTOkenRequest

asloobq approved these changes Nov 4, 2024

View reviewed changes

gmsdelmundo approved these changes Nov 5, 2024

View reviewed changes

atarassov-ttd reviewed Dec 2, 2024

View reviewed changes

sunnywu added 5 commits December 5, 2024 13:20

Code review feedback,

a002ad1

Mainly renaming RefreshTokenRequest/RefreshResponse to TokenRefreshRequest/TokenRefreshResponse

Renamed IdentityRequest/IdentityResponse to TokenGenerateRequest/Resp…

ea0b247

…onse

- Renamed RawUidResponse to IdentityMapResponseItem, MapRequest to Id…

4476ee1

…entityMapRequestItem - Renamed IUIDOperatorService.mapHashedDiiIdentity to mapHashedDii

1. Renamed FirstLevelHashIdentity/HashedDiiIdentity/RawUidIdentity to…

6bb1fb9

… FirstLevelHash/HashedDii/RawUid 2. Removed the abstract class UserIdentity 3. fixed a unit test as removing UserIdentity broke it

1. Renamed IdentityType to DiiType

a8f0915

2. In InputUtil, renamed Identity* member variable/methods to Dii* to indicate it's Dii 3. Change TokenUtils class getIdentityHash to getDiiHash and same for getDiiHashString

sunnywu force-pushed the syw-UID2-4159-token-gen-code-refactoring-UserIdentity branch from 78a70d4 to a8f0915 Compare December 10, 2024 06:44

Merge remote-tracking branch 'origin/main' into syw-UID2-4159-token-g…

7875d98

…en-code-refactoring-UserIdentity

jon8787 approved these changes Dec 13, 2024

View reviewed changes


		MappedIdentity mapIdentity(MapRequest request);
		RawUidResponse mapIdentity(MapRequest request);


		import java.time.Instant;

		//base class for all other HshedDii/FirstLevelHash/RawUIDIdentity class and define the basic common fields

		@@ -0,0 +1,30 @@
		package com.uid2.operator.model.userIdentity;

Final Refactoring - Syw UID2-4158 token gen code refactoring user identity #1123

Are you sure you want to change the base?

Final Refactoring - Syw UID2-4158 token gen code refactoring user identity #1123

Conversation

sunnywu commented Oct 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asloobq left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asloobq Nov 1, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asloobq left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sunnywu commented Oct 28, 2024 •

edited

Loading

asloobq Nov 1, 2024 •

edited

Loading