Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding scipion Field and replacing architecture by CPUFlags #957

Merged
merged 15 commits into from
Dec 10, 2024

Conversation

albertmena
Copy link
Collaborator

Changes in xmipp_portal required

Copy link
Collaborator

@MartinSalinas98 MartinSalinas98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does that variable intend to indicate? That xmipp is being installed with scipion? That scipion exists in the machine?

installer/api.py Outdated Show resolved Hide resolved
@albertmena albertmena changed the title adding scipion Field adding scipion Field and replacing architecture by CPUFlags Dec 5, 2024
@albertmena
Copy link
Collaborator Author

What does that variable intend to indicate? That xmipp is being installed with scipion? That scipion exists in the machine?

That xmipp is being installed with scipion

@MartinSalinas98
Copy link
Collaborator

That xmipp is being installed with scipion

Okay, and how does this variable work? is SCIPION_SOFTWARE set in the enviroment if you are running a command with scipion3 run ...? What's it's value?

@albertmena
Copy link
Collaborator Author

That xmipp is being installed with scipion

Okay, and how does this variable work? is SCIPION_SOFTWARE set in the enviroment if you are running a command with scipion3 run ...? What's it's value?

The variable is set when you run scipion run..., and its value is a path

installer/api.py Outdated Show resolved Hide resolved
installer/api.py Outdated Show resolved Hide resolved
@MartinSalinas98
Copy link
Collaborator

The variable is set when you run scipion run..., and its value is a path

Okay, then it's fine to use it. However isScipionUp is not the best possible name for this variable (in my opinion). Maybe installedByScipion makes more sense, lets you know Xmipp is being installed by/through Scipion.

Copy link
Collaborator

@MartinSalinas98 MartinSalinas98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __getCPUFlags can still be much simpler. Check other comments for reference code.

installer/api.py Outdated Show resolved Hide resolved
installer/api.py Outdated Show resolved Hide resolved
@albertmena albertmena marked this pull request as ready for review December 10, 2024 10:20
@albertmena
Copy link
Collaborator Author

Ready on asimov :-)

installer/api.py Outdated Show resolved Hide resolved
installer/api.py Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 10, 2024

@albertmena albertmena merged commit e72e2e9 into devel Dec 10, 2024
7 checks passed
@albertmena albertmena deleted the agm_ScipionField branch December 10, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants