merging project top and project subtomograms into project subtomograms #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix the test please |
| @@ -154,7 +154,7 @@ def createOutputStep(self): | |||
| # Input could be SetOfVolumes or SetOfSubtomograms | |||
| for item in input.iterItems(): | |||
| idx = item.getObjId() | |||
| p = Particle() | |||
| p = Particle(objId=item.getObjId()) | |||
There was a problem hiding this comment.
If project top is getting absorbed by project subtomograms, shouldn't this protocol get deleted?
Comment on lines
+257
to
+271
| # X axis | ||
| if dir == self.AXIS_X: | ||
| for zi in range(z): | ||
| for yi in range(y): | ||
| proj[yi, zi] = np.sum(volData[zi, yi, :]) | ||
| # Y axis | ||
| elif dir == self.AXIS_Y: | ||
| for zi in range(z): | ||
| for xi in range(x): | ||
| proj[zi, xi] = np.sum(volData[zi, :, xi]) | ||
| # Z axis | ||
| elif dir == self.AXIS_Z: | ||
| for xi in range(x): | ||
| for yi in range(y): | ||
| proj[yi, xi] = np.sum(volData[:, yi, xi]) |
There was a problem hiding this comment.
This should be separated into a private function
|
I need to properly understand the new features included in the protocol before i can really check this code. |
|
|
Not needed any more, can be replaced by #196. In such Pull Request, you can project in whichever axis you want just setting your For example, to proyect on to Z axis:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.